Skip to content

Commit

Permalink
Merged in bugfix/SHIBUI-711 (pull request #159)
Browse files Browse the repository at this point in the history
SHIBUI-711: Added references to IDs and labels for accessibility aria handling;

Approved-by: Shibui Jenkins <shibui.jenkins@gmail.com>
Approved-by: Ryan Mathis <rmathis@unicon.net>
  • Loading branch information
Jodie Muramoto authored and rmathis committed Aug 15, 2018
2 parents fd1230b + cc947e3 commit a25470f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="widget form-group">
<label [attr.for]="id" class="d-flex justify-content-between control-label">
<label [attr.for]="id" [id]="id" class="d-flex justify-content-between control-label">
<span>
{{ schema.title }}
<i class="fa fa-asterisk text-danger" aria-hidden="true" *ngIf="required"></i>
Expand All @@ -22,6 +22,6 @@
[placeholder]="schema.placeholder || ''"
[attr.disabled]="schema.readOnly?true:null"
role="textbox"
aria-label="Name ID Format (type for auto-complete)">
[attr.aria-label]="schema.title">
</auto-complete>
</div>
</div>
1 change: 1 addition & 0 deletions ui/src/app/shared/autocomplete/autocomplete.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
type="button"
aria-haspopup="true"
aria-expanded="false"
[attr.aria-labelledby]="id"
(click)="state.setState({menuOpen: !state.currentState.menuOpen})">
<i class="fa fa-caret-down"></i>
</button>
Expand Down

0 comments on commit a25470f

Please sign in to comment.