Local if no type is defined for output

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
docker · Oct 20, 2020 · 6751eb6 · 6751eb6
1 parent bf051e6
commit 6751eb6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/__tests__/buildx.test.ts b/__tests__/buildx.test.ts
@@ -80,7 +80,7 @@ describe('isLocalOrTarExporter', () => {
       [
         '.'
       ],
-      false
+      true
     ],
   ])(
     'given %p returns %p',

diff --git a/__tests__/context.test.ts b/__tests__/context.test.ts
@@ -95,7 +95,6 @@ describe('getArgs', () => {
         'buildx',
         'build',
         '--output', '.',
-        '--iidfile', '/tmp/.docker-build-push-jest/iidfile',
         '--secret', 'id=GIT_AUTH_TOKEN,src=/tmp/.docker-build-push-jest/.tmpname-jest',
         '--file', 'Dockerfile',
         'https://github.com/docker/build-push-action.git#test-jest'

diff --git a/dist/index.js b/dist/index.js
diff --git a/src/buildx.ts b/src/buildx.ts
@@ -33,6 +33,11 @@ export function isLocalOrTarExporter(outputs: string[]): Boolean {
     columns: false,
     relax_column_count: true
   })) {
+    // Local if no type is defined
+    // https://github.com/docker/buildx/blob/d2bf42f8b4784d83fde17acb3ed84703ddc2156b/build/output.go#L29-L43
+    if (output.length == 1 && !output[0].startsWith('type=')) {
+      return true;
+    }
     for (let [key, value] of output.map(chunk => chunk.split('=').map(item => item.trim()))) {
       if (key == 'type' && (value == 'local' || value == 'tar')) {
         return true;