Initial multi-purpose Grouper image #6
Merged
+662
−438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
added 2 commits
December 29, 2017 18:20
…cker/grouper_noVM into multi-stage-build * 'multi-purpose-grouper-image' of github.internet2.edu:docker/grouper_noVM: Update common.bash Create common.bash Create Jenkinsfile
|
This is the final set of commits for the time being as I'm more or less out of hours that were allocated to me. I'm not sure if there are additional ones available now that we are in the new year. Once this PR is merged, or better yet |
This pull request was closed.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at the ACAMP TechEx Grouper Container session led by Keith Wessel, I've produced a docker image (and test suite) that provides the Grouper components in a single image. Deployers can decide which role the images assumes at
runtime.While this images is quite clean and could be used today without issue, this images should be considered Alpha from a TIER standpoint as there are still more changes needed (secrets, centralizing config, documentation, etc). This is intended as a starting point for discussion about a single, mulit-role container vs an image per role model.
I'd recommend checking out the commit vs reviewing all the changes inline here as there have been a lot of changes.
Note: OpenJDK Java has been included to assist in testing/troubleshooting. The final version, does not necessarily need it included if including OpenJDK Zulu is considered wrong, bad, etc.