Add "if_needed" value for CREATE_NEW_DATABASE #7
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value means that the database is created only if
MYSQL_DATADIR
does not exist or is empty.Rationale: For midPoint dockerization we need to preserve MariaDB content across container re-creation that occurs when
docker-compose down
anddocker-compose up
commands are issued. Although this effect could be achieved by settingCREATE_NEW_DATABASE
to 1 on the first run and to 0 afterwards, it is quite complicated to ensure this. As an easier solution I see the introduction of a new valueif_needed
that would cause database creation only ifMYSQL_DATADIR
does not exist or is empty.