Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We pull in ssh2 via dockerode:
dockerode
↳ docker-modem
↳ ssh2
↳ cpu-features
Both it and `cpu-features` compile _optional_ native extensions using
OpenSSH and cpu-features (https://github.com/google/cpu_features) which
result in node-gyp generating two `.node` executables for these bindings
We have found that these bindings are very sensitive to the build env
which means that developer laptops, Actions and Codespaces result in
a diff in the `.node` files, something we seek to prevent in PRs in
order to detect cases where code changes are committed without actually
being applied to the `dist/` folder.
Since we do not actually SSH into any containers in our implementation,
let's just ignore these files in our distributed code rather than
make our build more convoluted/less portable.- Loading branch information