Lock down supported events to just dynamic

github · Oct 18, 2021 · 4171620 · 4171620
1 parent 9d81537
commit 4171620
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 39 deletions.
diff --git a/__tests__/inputs.test.ts b/__tests__/inputs.test.ts
@@ -25,20 +25,3 @@ test('loads dynamic', () => {
   expect(params?.jobToken).toEqual('xxx')
   expect(params?.credentialsToken).toEqual('yyy')
 })
-
-test('loads workflow_dispatch', () => {
-  const ctx = new Context()
-  ctx.eventName = 'workflow_dispatch'
-  ctx.payload = {
-    inputs: {
-      jobId: '1',
-      jobToken: 'xxx',
-      credentialsToken: 'yyy'
-    }
-  }
-
-  const params = getJobParameters(ctx)
-  expect(params?.jobId).toEqual(1)
-  expect(params?.jobToken).toEqual('xxx')
-  expect(params?.credentialsToken).toEqual('yyy')
-})
diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts
@@ -37,7 +37,7 @@ describe('run', () => {
   describe('when the run follows the happy path', () => {
     beforeAll(() => {
       process.env.GITHUB_EVENT_PATH = eventFixturePath('default')
-      process.env.GITHUB_EVENT_NAME = 'workflow_dispatch'
+      process.env.GITHUB_EVENT_NAME = 'dynamic'
       process.env.GITHUB_ACTOR = 'dependabot[bot]'
       context = new Context()
     })
@@ -62,7 +62,7 @@ describe('run', () => {
   describe('when the action is triggered on by a different actor', () => {
     beforeAll(() => {
       process.env.GITHUB_EVENT_PATH = eventFixturePath('default')
-      process.env.GITHUB_EVENT_NAME = 'workflow_dispatch'
+      process.env.GITHUB_EVENT_NAME = 'dynamic'
       process.env.GITHUB_ACTOR = 'classic-rando'
       context = new Context()
     })
@@ -118,7 +118,7 @@ describe('run', () => {
       )
 
       process.env.GITHUB_EVENT_PATH = eventFixturePath('default')
-      process.env.GITHUB_EVENT_NAME = 'workflow_dispatch'
+      process.env.GITHUB_EVENT_NAME = 'dynamic'
       process.env.GITHUB_ACTOR = 'dependabot[bot]'
       context = new Context()
     })
@@ -150,7 +150,7 @@ describe('run', () => {
         )
 
       process.env.GITHUB_EVENT_PATH = eventFixturePath('default')
-      process.env.GITHUB_EVENT_NAME = 'workflow_dispatch'
+      process.env.GITHUB_EVENT_NAME = 'dynamic'
       process.env.GITHUB_ACTOR = 'dependabot[bot]'
       context = new Context()
     })
@@ -182,7 +182,7 @@ describe('run', () => {
         )
 
       process.env.GITHUB_EVENT_PATH = eventFixturePath('default')
-      process.env.GITHUB_EVENT_NAME = 'workflow_dispatch'
+      process.env.GITHUB_EVENT_NAME = 'dynamic'
       process.env.GITHUB_ACTOR = 'dependabot[bot]'
       context = new Context()
     })
@@ -219,7 +219,7 @@ describe('run', () => {
         )
 
       process.env.GITHUB_EVENT_PATH = eventFixturePath('default')
-      process.env.GITHUB_EVENT_NAME = 'workflow_dispatch'
+      process.env.GITHUB_EVENT_NAME = 'dynamic'
       process.env.GITHUB_ACTOR = 'dependabot[bot]'
       context = new Context()
     })
@@ -256,7 +256,7 @@ describe('run', () => {
         )
 
       process.env.GITHUB_EVENT_PATH = eventFixturePath('default')
-      process.env.GITHUB_EVENT_NAME = 'workflow_dispatch'
+      process.env.GITHUB_EVENT_NAME = 'dynamic'
       process.env.GITHUB_ACTOR = 'dependabot[bot]'
       context = new Context()
     })

diff --git a/dist/main/index.js b/dist/main/index.js
diff --git a/dist/main/index.js.map b/dist/main/index.js.map
diff --git a/src/inputs.ts b/src/inputs.ts
@@ -3,16 +3,17 @@ import {Context} from '@actions/github/lib/context'
 import {WorkflowDispatchEvent} from '@octokit/webhooks-types'
 import {JobParameters} from './api-client'
 
+const DYNAMIC = 'dynamic'
+
 export function getJobParameters(ctx: Context): JobParameters | null {
-  switch (ctx.eventName) {
-    case 'dynamic':
-    case 'workflow_dispatch':
-      return fromWorkflowInputs(ctx)
+  if (ctx.eventName === DYNAMIC) {
+    return fromWorkflowInputs(ctx)
+  } else {
+    core.info(
+      `Dependabot Updater Action does not support '${ctx.eventName}' events.`
+    )
+    return null
   }
-  core.info(
-    `Dependabot Updater Action does not support '${ctx.eventName}' events.`
-  )
-  return null
 }
 
 function fromWorkflowInputs(ctx: Context): JobParameters {