Ensure the build fails on format/lint issues

github · Feb 10, 2022 · 8ba73ea · 8ba73ea
1 parent de2b791
commit 8ba73ea
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -27,8 +27,14 @@ jobs:
       - name: Install NPM dependencies
         run: npm ci
 
+      - name: Check formatting
+        run: npm run format-check
+
+      - name: Run linter
+        run: npm run lint-check
+
       - name: Run tests
-        run: npm run all
+        run: npm run test
 
       - run: git diff --quiet dist/
   test: # make sure the action works on a clean machine without building

diff --git a/package.json b/package.json
@@ -6,7 +6,9 @@
   "main": "src/main.ts",
   "scripts": {
     "format": "prettier --write **/*.ts",
+    "format-check": "prettier --check **/*.ts",
     "lint": "eslint --fix **/*.ts",
+    "lint-check": "eslint **/*.ts",
     "package": "ncc build -o dist/main src/main.ts --source-map --license licenses.txt && ncc build -o dist/cleanup src/cleanup.ts --source-map --license licenses.txt",
     "test": "SKIP_INTEGRATION_TESTS=true jest --detectOpenHandles",
     "test-integration": "jest --detectOpenHandles 'integration'",