Merge pull request #95 from github/brrygrdn/verify-build-mvp

Improve the build step so we use a fixed node version, Re-introduce verification the build is up to date in a PR
github · Sep 29, 2021 · 8f0ccd5 · 8f0ccd5
2 parents d553ef9 + b0fa004
commit 8f0ccd5
Show file tree

Hide file tree

Showing 7 changed files with 72 additions and 9,201 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,8 +12,16 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - name: Read .nvmrc
+        id: nvm
+        run: echo ::set-output name=NVMRC::$(cat .nvmrc)
+      - name: Setup Node.js
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ steps.nvm.outputs.NVMRC }}
       - run: npm ci
       - run: npm run all
+      - run: git diff --quiet
   test: # make sure the action works on a clean machine without building
     runs-on: ubuntu-latest
     steps:

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+12.22.6
diff --git a/README.md b/README.md
@@ -2,13 +2,14 @@
 
 ### Prerequisites
 
-**node**: e.g. `brew install node` on Mac
+**Node Version Manager**: e.g. `brew install nvm` on Mac
 
-**docker**: e.g. `brew install docker` on Mac
+**Docker**: e.g. `brew install docker` on Mac
 
 ### Project dependencies
 
 ```bash
+$ nvm use
 $ npm install
 ```
 

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map