Skip to content

Commit

Permalink
Prefer verbose npm command as bread crumb
Browse files Browse the repository at this point in the history
Likely due to ignorance of the npm ecosystem, I found myself thinking
that `npm ci` was perhaps a directive to execute a **C**ontinuous
**I**ntegration workflow, rather than doing a clean install. Updating
these references in case any future developers share my ignorance.
  • Loading branch information
Landon Grindheim authored and GitHub committed May 5, 2022
1 parent 353b165 commit a3d7673
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
node-version: ${{ steps.nvm.outputs.NVMRC }}

- name: Install npm dependencies
run: npm ci
run: npm clean-install

- name: Rebuild the dist/ directory
run: npm run package
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependabot-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
node-version: ${{ steps.nvm.outputs.NVMRC }}

- name: Install npm dependencies
run: npm ci
run: npm clean-install

# If we're reacting to a Docker PR, we have on extra step to refresh and check in the container manifest,
# this **must** happen before rebuilding dist/ so it uses the new version of the manifest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
node-version: ${{ steps.nvm.outputs.NVMRC }}

- name: Install npm dependencies
run: npm ci
run: npm clean-install

- name: Pre-fetch the pinned images
run: npm run fetch-images
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
node-version: ${{ steps.nvm.outputs.NVMRC }}

- name: Install npm dependencies
run: npm ci
run: npm clean-install

- name: Check formatting
run: npm run format-check
Expand Down

0 comments on commit a3d7673

Please sign in to comment.