Humanise the diff check failures

github · Feb 10, 2022 · aade2a8 · aade2a8
1 parent 7db94e5
commit aade2a8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml
@@ -1,4 +1,4 @@
-name: Check dist/
+name: Check dist
 
 on:
   pull_request:
@@ -32,7 +32,7 @@ jobs:
         run: npm run package
 
       - name: Compare the expected and actual dist/ directories
-        run: git diff --quiet dist/
+        run: script/check-diff
   verify-index-js: # make sure the entrypoint js files run on a clean machine without compiling first
     runs-on: ubuntu-latest
     steps:

diff --git a/script/check-diff b/script/check-diff
@@ -0,0 +1,9 @@
+#!/bin/bash
+
+git diff --quiet dist/
+retVal=$?
+if [ $retVal -ne 0 ]; then
+  echo "Detected uncommitted changes after build:"
+  git --no-pager diff dist/
+  exit 1
+fi