Skip to content

Commit

Permalink
Provide empty strings as fallback proxy values
Browse files Browse the repository at this point in the history
  • Loading branch information
Landon Grindheim authored and GitHub committed May 4, 2022
1 parent fe3f06e commit bba2211
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
6 changes: 3 additions & 3 deletions dist/main/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/main/index.js.map

Large diffs are not rendered by default.

8 changes: 5 additions & 3 deletions src/proxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,11 @@ export class ProxyBuilder {
AttachStdout: true,
AttachStderr: true,
Env: [
`http_proxy=${process.env.http_proxy || process.env.HTTP_PROXY}`,
`https_proxy=${process.env.https_proxy || process.env.HTTPS_PROXY}`,
`no_proxy=${process.env.no_proxy || process.env.NO_PROXY}`,
`http_proxy=${process.env.http_proxy || process.env.HTTP_PROXY || ''}`,
`https_proxy=${
process.env.https_proxy || process.env.HTTPS_PROXY || ''
}`,
`no_proxy=${process.env.no_proxy || process.env.NO_PROXY || ''}`,
`JOB_ID=${jobId}`
],
Entrypoint: [
Expand Down

0 comments on commit bba2211

Please sign in to comment.