Refactor Validator construction

internet2 · May 11, 2018 · 3b9f7ff · 3b9f7ff
1 parent 514b9d2
commit 3b9f7ff
Showing 1 changed file with 4 additions and 15 deletions.
diff --git a/src/main/java/uk/org/iay/incommon/validator/api/ValidatorsApiController.java b/src/main/java/uk/org/iay/incommon/validator/api/ValidatorsApiController.java
@@ -62,28 +62,17 @@ public ValidatorsApiController(final HttpServletRequest req, final ValidatorColl
         validatorCollection = valc;
     }
 
-    /**
-     * Make a {@link Validator} from an identifier and description.
-     *
-     * @param id identifier for the validator
-     * @param description description of the validator
-     * @return a {@link Validator}
-     */
-    private Validator makeValidator(final String id, final String description) {
-        final Validator v = new Validator();
-        v.setValidatorId(id);
-        v.setDescription(description);
-        return v;
-    }
-
     @Override
     public ResponseEntity<List<Validator>> getValidators() {
         final String accept = request.getHeader("Accept");
         LOG.info("accept {}", accept);
         if (accept != null && accept.contains("application/json")) {
             final List<Validator> validators = new ArrayList<>();
             for (final ValidatorCollection.Entry entry : validatorCollection.getEntries()) {
-                validators.add(makeValidator(entry.getId(), entry.getDescription()));
+                final Validator v = new Validator();
+                v.setValidatorId(entry.getId());
+                v.setDescription(entry.getDescription());
+                validators.add(v);
             }
             return new ResponseEntity<List<Validator>>(validators, HttpStatus.OK);
         }