Skip to content

Commit

Permalink
Refactor Shibboleth SP logging configuration
Browse files Browse the repository at this point in the history
Refactor the Shibboleth SP logging configuration so that default
shibd.logger, native.logger, and console.logger with details appropriate
for Docker images are in the base and can be easily copied into images.
Remove shibd.logger and native.logger from the COmanage Registry and
Mailman images as a result.
  • Loading branch information
skoranda committed Aug 23, 2019
1 parent 30e5833 commit 302a81f
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 76 deletions.
3 changes: 0 additions & 3 deletions comanage-registry-mailman/apache-shib/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ RUN /usr/sbin/useradd --system _shibd \
&& rm -rf shibboleth \
&& ln -s /etc/shibboleth shibboleth

COPY --chown=_shibd:_shibd shibd.logger /etc/shibboleth/shibd.logger
COPY --chown=_shibd:_shibd native.logger /etc/shibboleth/native.logger

COPY --from=comanage-registry-base /usr/local/lib/comanage_shibboleth_sp_utils.sh /usr/local/lib/comanage_shibboleth_sp_utils.sh

COPY supervisord.conf /usr/local/etc/supervisord.conf
Expand Down
3 changes: 3 additions & 0 deletions comanage-registry-shibboleth-sp-base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ RUN wget -O shibboleth-sp.tar.gz "${SHIBBOLETH_SP_URL}" \

COPY shib2.load /opt/shibboleth-sp/etc/shibboleth/shib2.load
COPY shibboleth2.xml.template /opt/shibboleth-sp/etc/shibboleth/shibboleth2.xml.template
COPY shibd.logger /opt/shibboleth-sp/etc/shibboleth/shibd.logger
COPY native.logger /opt/shibboleth-sp/etc/shibboleth/native.logger
COPY console.logger /opt/shibboleth-sp/etc/shibboleth/console.logger

RUN apt-get update && apt-get install -y \
&& apt-get purge -y \
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
# set overall behavior
log4j.rootCategory=INFO, native_log
log4j.rootCategory=WARN, console

# fairly verbose for DEBUG, so generally leave at WARN/INFO
log4j.category.XMLTooling.XMLObject=WARN
log4j.category.XMLTooling.KeyInfoResolver=WARN
log4j.category.Shibboleth.IPRange=WARN
log4j.category.Shibboleth.PropertySet=WARN
# fairly verbose for DEBUG, so generally leave at INFO
log4j.category.XMLTooling.XMLObject=INFO
log4j.category.XMLTooling.KeyInfoResolver=INFO
log4j.category.Shibboleth.IPRange=INFO
log4j.category.Shibboleth.PropertySet=INFO

# raise for low-level tracing of SOAP client HTTP/SSL behavior
log4j.category.XMLTooling.libcurl=WARN
log4j.category.XMLTooling.libcurl=INFO

# useful categories to tune independently:
#
Expand All @@ -27,6 +26,7 @@ log4j.category.XMLTooling.libcurl=WARN

# define the appender

log4j.appender.native_log=org.apache.log4j.ConsoleAppender
log4j.appender.native_log.layout=org.apache.log4j.PatternLayout
log4j.appender.native_log.layout.ConversionPattern=native_log %p %c %x: %m%n
log4j.appender.console=org.apache.log4j.ConsoleAppender
#log4j.appender.console.layout=org.apache.log4j.BasicLayout
log4j.appender.console.layout=org.apache.log4j.PatternLayout
log4j.appender.console.layout.ConversionPattern=console_log %d{%Y-%m-%d %H:%M:%S} %p %c %x: %m%n
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ log4j.category.XMLTooling.libcurl=WARN
#log4j.category.XMLTooling.StorageService=DEBUG

# define the appender

log4j.appender.native_log=org.apache.log4j.ConsoleAppender
log4j.appender.native_log.layout=org.apache.log4j.PatternLayout
log4j.appender.native_log.layout.ConversionPattern=native_log %p %c %x: %m%n
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ log4j.ownAppenders.Shibboleth-TRANSACTION=true
#log4j.category.Shibboleth-TRANSACTION.Logout=WARN

# define the appenders

log4j.appender.shibd_log=org.apache.log4j.ConsoleAppender
log4j.appender.shibd_log.layout=org.apache.log4j.PatternLayout
log4j.appender.shibd_log.layout.ConversionPattern=shibd_log %d{%Y-%m-%d %H:%M:%S} %p %c %x: %m%n
Expand Down
3 changes: 0 additions & 3 deletions comanage-registry-shibboleth-sp/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ RUN /usr/sbin/useradd --system _shibd \
&& ln -s /etc/shibboleth shibboleth \
&& a2enmod shib2

COPY --chown=_shibd:_shibd shibd.logger /etc/shibboleth/shibd.logger
COPY --chown=_shibd:_shibd native.logger /etc/shibboleth/native.logger

COPY supervisord.conf /usr/local/etc/supervisord.conf

COPY 000-comanage.conf /etc/apache2/sites-available/
Expand Down
57 changes: 0 additions & 57 deletions comanage-registry-shibboleth-sp/shibd.logger

This file was deleted.

0 comments on commit 302a81f

Please sign in to comment.