Skip to content

Commit

Permalink
Adopt new parent beans
Browse files Browse the repository at this point in the history
  • Loading branch information
iay committed Jul 8, 2024
1 parent 5fc3bf7 commit 31adc88
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 50 deletions.
6 changes: 3 additions & 3 deletions mdx/at_aconet/beans.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<bean id="at_aconet_productionAggregate" parent="mda.DOMResourceSourceStage">
<property name="parserPool" ref="parserPool"/>
<property name="DOMResource">
<bean parent="HTTPResource">
<bean parent="mda.HTTPResource">
<constructor-arg name="client" ref="httpClient"/>
<constructor-arg name="url" ref="at_aconet_registrarAggregate_url"/>
</bean>
Expand All @@ -43,7 +43,7 @@
<bean id="at_aconet_edugainAggregate" parent="mda.DOMResourceSourceStage">
<property name="parserPool" ref="parserPool"/>
<property name="DOMResource">
<bean parent="HTTPResource">
<bean parent="mda.HTTPResource">
<constructor-arg name="client" ref="httpClient"/>
<constructor-arg name="url" ref="at_aconet_edugainAggregate_url"/>
</bean>
Expand All @@ -53,7 +53,7 @@
<!--
Signing certificate.
-->
<bean id="at_aconet_signingCertificate" parent="X509CertificateFactoryBean"
<bean id="at_aconet_signingCertificate" parent="mda.X509CertificateFactoryBean"
p:resource="classpath:at_aconet/aconet-aai-metadata-signing.crt"/>

<!--
Expand Down
46 changes: 9 additions & 37 deletions mdx/common-beans.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,6 @@
<bean id="FileSystemResource" abstract="true"
class="org.springframework.core.io.FileSystemResource"/>

<!--
Shibboleth-defined Resource class parent bean.
-->
<bean id="HTTPResource" abstract="true"
class="net.shibboleth.shared.spring.httpclient.resource.HTTPResource"/>

<!--
component_parent
Expand Down Expand Up @@ -119,28 +113,8 @@
</property>
</bean>

<!-- *** Parent beans for Shibboleth spring-extensions factory beans. *** -->

<bean id="DOMDocumentFactoryBean" abstract="true"
class="net.shibboleth.shared.spring.factory.DOMDocumentFactoryBean"/>

<bean id="PKCS11PrivateKeyFactoryBean" abstract="true"
class="net.shibboleth.shared.spring.security.factory.PKCS11PrivateKeyFactoryBean"/>

<bean id="PrivateKeyFactoryBean" abstract="true"
class="net.shibboleth.shared.spring.security.factory.PrivateKeyFactoryBean"/>

<bean id="PublicKeyFactoryBean" abstract="true"
class="net.shibboleth.shared.spring.security.factory.PublicKeyFactoryBean"/>

<bean id="X509CertificateChainFactoryBean" abstract="true"
class="net.shibboleth.shared.spring.security.factory.X509CertificateChainFactoryBean"/>

<bean id="X509CertificateFactoryBean" abstract="true"
class="net.shibboleth.shared.spring.security.factory.X509CertificateFactoryBean"/>

<!-- *** Default Shibboleth component bean id property from Spring bean id *** -->
<bean class="net.shibboleth.shared.spring.config.IdentifiableBeanPostProcessor" lazy-init="false"/>
<bean parent="mda.IdentifiableBeanPostProcessor" lazy-init="false"/>


<!--
Expand All @@ -155,11 +129,11 @@
<bean id="conversionService" class="org.springframework.context.support.ConversionServiceFactoryBean">
<property name="converters">
<set>
<bean class="net.shibboleth.shared.spring.config.StringToDurationConverter" />
<bean class="net.shibboleth.shared.spring.config.StringToIPRangeConverter" />
<bean class="net.shibboleth.shared.spring.config.BooleanToPredicateConverter" />
<bean class="net.shibboleth.shared.spring.config.StringBooleanToPredicateConverter" />
<bean class="net.shibboleth.shared.spring.config.StringToResourceConverter" />
<bean parent="mda.StringToDurationConverter"/>
<bean parent="mda.StringToIPRangeConverter"/>
<bean parent="mda.BooleanToPredicateConverter"/>
<bean parent="mda.StringBooleanToPredicateConverter"/>
<bean parent="mda.StringToResourceConverter"/>
</set>
</property>
</bean>
Expand Down Expand Up @@ -286,7 +260,7 @@
A NamespaceContext that assigns the usual prefix for each of the commonly used XML namespaces.
This is used in the evaluation of XPath expressions.
-->
<bean id="commonNamespaces" class="net.shibboleth.metadata.dom.SimpleNamespaceContext">
<bean id="commonNamespaces" parent="mda.SimpleNamespaceContext">
<constructor-arg>
<util:map map-class="java.util.HashMap">
<entry key="alg" value-ref="alg_namespace"/>
Expand Down Expand Up @@ -989,8 +963,7 @@
These options can be removed once the underlying issue has been resolved.
-->
<bean id="httpClientBuilder"
class="net.shibboleth.shared.httpclient.HttpClientBuilder"
<bean id="httpClientBuilder" parent="mda.HttpClientBuilder"
p:connectionDisregardTLSCertificate="true"
p:socketTimeout="PT100S"
p:connectionTimeout="PT100S"
Expand All @@ -1008,8 +981,7 @@
A pre-configured parser pool for use by source stages.
-->
<bean id="parserPool" parent="component_parent"
class="net.shibboleth.shared.xml.impl.BasicParserPool"
<bean id="parserPool" parent="mda.BasicParserPool"
p:ignoreComments="false"
p:ignoreElementContentWhitespace="false"/>

Expand Down
4 changes: 2 additions & 2 deletions mdx/int_edugain/beans.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<bean id="int_edugain_productionAggregate" parent="mda.DOMResourceSourceStage">
<property name="parserPool" ref="parserPool"/>
<property name="DOMResource">
<bean parent="HTTPResource">
<bean parent="mda.HTTPResource">
<constructor-arg name="client" ref="httpClient"/>
<constructor-arg name="url"
ref="int_edugain_${int.edugain.aggregate.name:production}Aggregate_url"/>
Expand All @@ -72,7 +72,7 @@
<!--
eduGAIN signing certificate.
-->
<bean id="int_edugain_signingCertificate" parent="X509CertificateFactoryBean"
<bean id="int_edugain_signingCertificate" parent="mda.X509CertificateFactoryBean"
p:resource="classpath:int_edugain/mds-v2.cer"/>

<!--
Expand Down
10 changes: 5 additions & 5 deletions mdx/uk/beans.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
<bean id="uk_exportAggregate" parent="mda.DOMResourceSourceStage">
<property name="parserPool" ref="parserPool"/>
<property name="DOMResource">
<bean parent="HTTPResource">
<bean parent="mda.HTTPResource">
<constructor-arg name="client" ref="httpClient"/>
<constructor-arg name="url" ref="uk_exportAggregate_url"/>
</bean>
Expand All @@ -121,7 +121,7 @@
<bean id="uk_productionAggregate" parent="mda.DOMResourceSourceStage">
<property name="parserPool" ref="parserPool"/>
<property name="DOMResource">
<bean parent="HTTPResource">
<bean parent="mda.HTTPResource">
<constructor-arg name="client" ref="httpClient"/>
<constructor-arg name="url" ref="uk_productionAggregate_url"/>
</bean>
Expand All @@ -132,7 +132,7 @@
<!--
Metadata signing certificate.
-->
<bean id="uk_signingCertificate" parent="X509CertificateFactoryBean"
<bean id="uk_signingCertificate" parent="mda.X509CertificateFactoryBean"
p:resource="classpath:uk/ukfederation-2014.pem"/>


Expand Down Expand Up @@ -177,7 +177,7 @@
This bean contains the contents of the members.xml file as a DOM Document.
-->
<bean id="uk_membersDocument" parent="DOMDocumentFactoryBean">
<bean id="uk_membersDocument" parent="mda.DOMDocumentFactoryBean">
<property name="resource">
<bean parent="FileSystemResource" c:_="${members.dir}/members.xml"/>
</property>
Expand All @@ -190,7 +190,7 @@
This bean loads the schema for the members.xml file as a DOM Document.
-->
<bean id="uk_membersSchemaDocument" parent="DOMDocumentFactoryBean">
<bean id="uk_membersSchemaDocument" parent="mda.DOMDocumentFactoryBean">
<property name="resource">
<bean parent="FileSystemResource" c:_="${members.dir}/ukfederation-members.xsd"/>
</property>
Expand Down
2 changes: 1 addition & 1 deletion mdx/uk/mdq-multisign.xml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
<!-- Sign each item. -->
<bean id="perform.signature" parent="mda.XMLSignatureSigningStage">
<property name="privateKey">
<bean parent="PKCS11PrivateKeyFactoryBean"
<bean parent="mda.PKCS11PrivateKeyFactoryBean"
p:pkcs11Config="${sign.pkcs11Config}"
p:keyPassword="${sign.keyPassword}"
p:keyAlias="${sign.keyAlias}"
Expand Down
4 changes: 2 additions & 2 deletions mdx/us_incommon/beans.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<bean id="us_incommon_productionAggregate" parent="mda.DOMResourceSourceStage">
<property name="parserPool" ref="parserPool"/>
<property name="DOMResource">
<bean parent="HTTPResource">
<bean parent="mda.HTTPResource">
<constructor-arg name="client" ref="httpClient"/>
<constructor-arg name="url" ref="us_incommon_productionAggregate_url"/>
</bean>
Expand All @@ -44,7 +44,7 @@
<!--
InCommon signing certificate.
-->
<bean id="us_incommon_signingCertificate" parent="X509CertificateFactoryBean"
<bean id="us_incommon_signingCertificate" parent="mda.X509CertificateFactoryBean"
p:resource="classpath:us_incommon/inc-md-cert.pem"/>

<!--
Expand Down

0 comments on commit 31adc88

Please sign in to comment.