Skip to content

Commit

Permalink
Upgrade to xmlsectool version 1.1.1. This version addresses the issue…
Browse files Browse the repository at this point in the history
… by which previous versions included unnecessary xmlns:xml prefix declarations:

https://bugs.internet2.edu/jira/browse/SECT-6

This fix means that it is no longer necessary to pipe xmlsectool's output through an identity transform to remove those declarations, so that step has been removed from the process as well.  This should speed the signing process up a little.  The only resulting change in output is one surplus xmlns:ds declaration on the signature, as described here:

https://bugs.internet2.edu/jira/browse/SECT-8

This is how metadatatool used to do things though, so it isn't a problem.
  • Loading branch information
iay committed Aug 11, 2010
1 parent bff284e commit 575ba99
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@
<arg value="--keyPassword"/>
<arg value="${keystore.pass}"/>
<arg value="--outFile"/>
<arg value="${xml.dir}/temp.xml"/>
<arg value="${xml.dir}/@{o}"/>
<arg value="--referenceIdAttributeName"/>
<arg value="ID"/>
<!--
Expand All @@ -633,20 +633,6 @@
</args>
</XMLSECTOOL>

<!--
Perform identity transform, into the real output file.
This will remove some problematic "xml" namespace prefix
declarations without affecting the signature.
-->
<XALAN
i="temp.xml"
o="@{o}"
x="identity.xsl"/>

<!-- delete the temporary file now that we're finished with it -->
<delete file="${xml.dir}/temp.xml" quiet="true" verbose="false"/>

<!-- Force the output file to use Unix line endings -->
<fixcrlf file="${xml.dir}/@{o}" eol="lf"/>

Expand Down
Binary file removed tools/xmlsectool/lib/xmlsectool-1.1.0.jar
Binary file not shown.
Binary file added tools/xmlsectool/lib/xmlsectool-1.1.1.jar
Binary file not shown.

0 comments on commit 575ba99

Please sign in to comment.