Skip to content

Commit

Permalink
Centralise setting of ID attribute on aggregates
Browse files Browse the repository at this point in the history
  • Loading branch information
iay committed Sep 14, 2017
1 parent 46e6c9c commit 90d95ec
Showing 1 changed file with 11 additions and 19 deletions.
30 changes: 11 additions & 19 deletions mdx/uk/generate.xml
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,23 @@
<!--
assembleAggregate
Assemble a UK-style aggregate with an appropriate validUntil.
Assemble a UK-style aggregate with an appropriate validUntil and ID.
-->
<bean id="assembleAggregate" parent="mda.CompositeStage">
<property name="composedStages">
<list>
<ref bean="uk_assemble"/>
<bean parent="mda.SetValidUntilStage" p:validityDuration="${validUntil.aggregate.duration}"/>
<!--
setStaticID
Set the item's ID attribute to the static string "_".
-->
<bean id="setStaticID" parent="mda.GenerateIdStage">
<constructor-arg>
<bean parent="ukf.FixedStringIdentifierGenerationStrategy" c:_="_"/>
</constructor-arg>
</bean>
</list>
</property>
</bean>
Expand All @@ -101,17 +111,6 @@
</property>
</bean>

<!--
setStaticID
Set the item's ID attribute to the static string "_".
-->
<bean id="setStaticID" parent="mda.GenerateIdStage">
<constructor-arg>
<bean parent="ukf.FixedStringIdentifierGenerationStrategy" c:_="_"/>
</constructor-arg>
</bean>


<!--
*****************************************
Expand Down Expand Up @@ -303,7 +302,6 @@

<ref bean="assembleAggregate"/>
<ref bean="uk_finaliseProduction"/>
<ref bean="setStaticID"/>
<ref bean="uk_normaliseNamespaces"/>

<!-- production aggregate MUST pass publishability test -->
Expand Down Expand Up @@ -373,7 +371,6 @@

<ref bean="stripMdattrNamespace"/>
<ref bean="uk_finaliseProduction"/>
<ref bean="setStaticID"/>
<ref bean="uk_normaliseNamespaces"/>

<!-- WAYF aggregate MUST pass publishability test -->
Expand Down Expand Up @@ -492,7 +489,6 @@
<ref bean="stripEmptyExtensions"/>

<ref bean="CDSFinalise"/>
<ref bean="setStaticID"/>
<ref bean="CDSNormaliseNamespaces"/>

<!-- schema validity check MUST pass -->
Expand Down Expand Up @@ -546,7 +542,6 @@
<ref bean="assembleAggregate"/>
<ref bean="stripEmptyExtensions"/>
<ref bean="uk_finaliseFallback"/>
<ref bean="setStaticID"/>
<ref bean="uk_normaliseFallback"/>

<!-- fallback aggregate MUST pass publishability test -->
Expand Down Expand Up @@ -601,7 +596,6 @@
<ref bean="assembleAggregate"/>
<ref bean="stripEntityScopes"/>
<ref bean="uk_finaliseTest"/>
<ref bean="setStaticID"/>
<ref bean="uk_normaliseTest"/>

<!-- test aggregate MUST pass publishability test -->
Expand Down Expand Up @@ -727,7 +721,6 @@
<ref bean="stripEntityScopes"/>
<ref bean="stripEmptyExtensions"/>
<ref bean="uk_finaliseExport"/>
<ref bean="setStaticID"/>

<bean id="uk_normaliseExport" parent="mda.XSLTransformationStage"
p:XSLResource="classpath:uk/ns_norm_export.xsl"/>
Expand Down Expand Up @@ -843,7 +836,6 @@
<ref bean="stripEntityScopes"/>
<ref bean="stripEmptyExtensions"/>
<ref bean="uk_finaliseExport"/>
<ref bean="setStaticID"/>

<bean id="uk_normaliseExportPreview" parent="mda.XSLTransformationStage"
p:XSLResource="classpath:uk/ns_norm_export_preview.xsl"/>
Expand Down

0 comments on commit 90d95ec

Please sign in to comment.