Include expired but whitelisted certificates at a comment level rathe…

…r than suppressing entirely. This means that it will still be visible if there is another error on the certificate, but won't prompt output if the certificate is otherwise OK.
InCommon · Apr 9, 2013 · 97ebf89 · 97ebf89
1 parent 67c0951
commit 97ebf89
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/build/check_embedded.pl b/build/check_embedded.pl
@@ -394,12 +394,16 @@ sub comment {
 		#
 		if ($days < -$longExpiredDays) {
 			my $d = floor(-$days);
-			if (!defined($expiry_whitelist{$fingerprint})) {
+			if (defined($expiry_whitelist{$fingerprint})) {
+				comment("EXPIRED LONG AGO ($d days; $notAfter)");
+			} else {
 				error("EXPIRED LONG AGO ($d days; $notAfter)");
 				comment("fingerprint $fingerprint");
 			}
 		} elsif ($days < 0) {
-			if (!defined($expiry_whitelist{$fingerprint})) {
+			if (defined($expiry_whitelist{$fingerprint})) {
+				comment("EXPIRED ($notAfter)");
+			} else {
 				error("EXPIRED ($notAfter)");
 				comment("fingerprint $fingerprint");
 			}