Skip to content

Commit

Permalink
Reclassify Thawte root, which is 1024-bit. Emphasise removal of KeyNa…
Browse files Browse the repository at this point in the history
…me on non trust fabric issuers.
  • Loading branch information
iay committed Feb 1, 2013
1 parent 8e55ad9 commit 9de40dc
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions build/check_embedded.pl
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
$issuerMark{'GlobalSign Organization Validation CA'} = 'i';
$issuerMark{'GlobalSign Primary Secure Server CA'} = 'i';
$issuerMark{'GlobalSign ServerSign CA'} = 'i';
$issuerMark{'Thawte Premium Server CA'} = '*'; # root directly signs
$issuerMark{'Thawte Premium Server CA'} = '<'; # root directly signs; 1024 bit key

# NOT from master.xml
$issuerMark{'Cybertrust Educational CA'} = 'x'; # ex trust root
Expand Down Expand Up @@ -434,9 +434,10 @@ sub comment {
#
# Now, adjust for our expectations.
#
# Pretty much any certificate is fine if we don't have a KeyName.
#
if (!$hasKeyName) {
#
# Pretty much any certificate is fine if we don't have a KeyName.
#
if ($error eq 'self signed certificate') {
$error = '';
comment("self signed certificate");
Expand All @@ -446,14 +447,15 @@ sub comment {
} elsif ($clientOK) {
# $error = "certificate matches trust fabric; add KeyName?";
}
}

if ($hasKeyName && $error eq 'self signed certificate') {
$error = 'self signed certificate: remove KeyName?';
}

if ($error eq 'unable to get local issuer certificate') {
$error = "non trust fabric issuer: $issuerCN";
} else {
#
# If a KeyName is present, we must match the trust fabric.
#
if ($error eq 'self signed certificate') {
$error = 'self signed certificate: remove KeyName?';
} elsif ($error eq 'unable to get local issuer certificate') {
$error = "non trust fabric issuer: $issuerCN: remove KeyName?";
}
}

if ($error eq 'certificate has expired' && $days < 0) {
Expand Down

0 comments on commit 9de40dc

Please sign in to comment.