Skip to content

Commit

Permalink
Split out setting the mda keyPassword property into a separate target
Browse files Browse the repository at this point in the history
If sign.uk.keyPassword is provided, then the target is skipped and the
property never gets set.
  • Loading branch information
Rhys Smith committed Oct 26, 2016
1 parent 3fbdf3a commit 9e5dd83
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1712,6 +1712,9 @@
<input addproperty="sign.uk.keyPassword">
Please enter the password for the keystores:
</input>
</target>

<target name="set.mda.sign.uk.keyPassword">
<property name="mda.sign.keyPassword" value="${sign.uk.keyPassword}"/>
</target>

Expand All @@ -1730,7 +1733,7 @@
<!--
Signs the unsigned aggregates
-->
<target name="samlmd.aggregates.sign" depends="get.sign.uk.keyPassword">
<target name="samlmd.aggregates.sign" depends="get.sign.uk.keyPassword, set.mda.sign.uk.keyPassword">
<echo>Signing unsigned aggregates.</echo>

<echo>Signing UKfed prod metadata.</echo>
Expand Down Expand Up @@ -1789,7 +1792,7 @@
individual documents and write them as individual files into a
destination directory.
-->
<target name="samlmd.mdq.sign" depends="get.sign.uk.keyPassword">
<target name="samlmd.mdq.sign" depends="get.sign.uk.keyPassword, set.mda.sign.uk.keyPassword">
<property name="mda.mdq.input" value="${output.dir}/${mdaggr.prod.unsigned}"/>
<echo>Generating per-entity metadata in ${mda.mdq.output}</echo>
<echo> from production aggregate in ${mda.mdq.input}</echo>
Expand All @@ -1804,7 +1807,7 @@
entity rather than the whole production aggregate, because dev environment
PKCS#11 tokens are not fast enough to sign everything.
-->
<target name="samlmd.mdq.sign.test" depends="get.sign.uk.keyPassword">
<target name="samlmd.mdq.sign.test" depends="get.sign.uk.keyPassword, set.mda.sign.uk.keyPassword">
<property name="mda.mdq.input" value="${entities.dir}/uk000006.xml"/>
<echo>Generating per-entity metadata in ${mda.mdq.output}</echo>
<echo> from test metadata in ${mda.mdq.input}</echo>
Expand Down

0 comments on commit 9e5dd83

Please sign in to comment.