Skip to content

Commit

Permalink
Protect against CR characters in metadata.
Browse files Browse the repository at this point in the history
CR characters in metadata (which can only appear as the result of a character reference)
can trigger the SSPCPP-684 bug in the Shibboleth SP. So, prevent them from appearing.
  • Loading branch information
iay committed Apr 15, 2016
1 parent 56ea82d commit e5435a3
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
3 changes: 3 additions & 0 deletions mdx/common-beans.xml
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@

<!-- *** Parent beans for ukf-mda. *** -->

<bean id="CRDetectionStage" abstract="true" parent="stage_parent"
class="uk.org.ukfederation.mda.dom.CRDetectionStage"/>

<bean id="EntityAttributeAddingStage" abstract="true" parent="stage_parent"
class="uk.org.ukfederation.mda.dom.saml.mdattr.EntityAttributeAddingStage"/>

Expand Down
9 changes: 9 additions & 0 deletions mdx/validation-beans.xml
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,14 @@
*********************
-->

<!--
check_cr
Check for the presence of CR characters in text content or attribute values.
This protects against SSPCPP-684 in the Shibboleth SP.
-->
<bean id="check_cr" parent="CRDetectionStage"/>

<!--
check_misc
-->
Expand Down Expand Up @@ -563,6 +571,7 @@
<ref bean="check_adfs"/>
<ref bean="check_algsupport"/>
<ref bean="check_bindings"/>
<ref bean="check_cr"/>
<ref bean="check_hoksso"/>
<ref bean="check_idpdisc"/>
<ref bean="check_incmd"/>
Expand Down
Binary file not shown.

0 comments on commit e5435a3

Please sign in to comment.