Commits
86a804f9a7
Name already in use
Commits on Jun 3, 2021
-
Allow the codeql-action to run packages
This commit adds a `packs` option to the codeql-config.yml file. Users can specify a list of ql packs to include in the analysis. For a single language analysis, the packs property looks like this: ```yaml packs: - pack-scope/pack-name1@1.2.3 - pack-scope/pack-name2 # no explicit version means download the latest ``` For multi-language analysis, you must key the packs block by lanaguage: ```yaml packs: cpp: - pack-scope/pack-name1@1.2.3 - pack-scope/pack-name2 java: - pack-scope/pack-name3@1.2.3 - pack-scope/pack-name4 ``` This implementation adds a new analysis run (alongside custom and builtin runs). The unit tests indicate that the correct commands are being run, but I have not actually tried this with a real CLI. Also, convert `instanceof Array` to `Array.isArray` since that is sightly better in some situations. See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#instanceof_vs_isarray
Andrew Eisenberg committedJun 3, 2021 Copy the full SHA 86a804fView commit details -
Merge pull request #539 from github/aeisenberg/env-vars
Add environment variables to signal feature and version to the CLI
Andrew Eisenberg authored and GitHub committedJun 3, 2021 Copy the full SHA cbdf0dfView commit details -
Cleaning up comments around env vars
Also, move `getTemporaryDirectory` back to `actions-util`.
Andrew Eisenberg committedJun 3, 2021 Unverified
No user is associated with the committer email.Copy the full SHA f60ef17View commit details
Commits on Jun 2, 2021
-
Fix Unguarded actions library use code scanning error
Must access the env var directly in order to avoid recursive calls to `getRequiredEnvParam`.
Andrew Eisenberg committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA cc0733fView commit details -
Merge branch 'main' into aeisenberg/env-vars
Andrew Eisenberg committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 082575fView commit details -
Remove local environment running
This is a functionality that never worked perfectly and hasn't been used for a while. This allows developers to run the action on their local machine, but the run was always flaky and never 100% mirrored what was happening on the actions runner.
Andrew Eisenberg committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 2c2ebdcView commit details -
Add environment variables to signal feature and version to the CLI
This PR ensures environment variables are set before any invocation of the CLI. Here is a list of vars that are set: https://github.com/github/codeql-coreql-team/issues/1124#issuecomment-852463521 This ensures the CLI knows the features and versions of the containing actions/runner. Additionally: - Fix the user agent so that it more closely aligns with user agent spec - Refactor environment variable initialization so that it all happens in one place and call. - Move Mode, getRequiredEnvParam, setMode, getMode out of actions-util and into util. actions-util is meant for utils only called by the action, not the runner. The `prepareLocalRunEnvironment()` method is most likely deprecated and should be removed. I originally added it because I had a way of working where I would run the action from my local machine to test out changes, but this was always a little flaky. So, I no longer use this way of working. I will probably remove it soon.
Andrew Eisenberg committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 3708898View commit details -
Merge pull request #542 from github/robertbrignull/import-actions-lib
Update unguarded-action-lib.ql to catch uses of actions-util.ts
Aditya Sharad authored and GitHub committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 1ec2fd7View commit details -
Update unguarded-action-lib.ql
Robert authored and GitHub committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 61b5618View commit details -
Merge pull request #541 from github/update-supported-enterprise-serve…
…r-versions Update supported GitHub Enterprise Server versions.
Andrew Eisenberg authored and GitHub committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 4ac9009View commit details -
Merge branch 'main' into update-supported-enterprise-server-versions
Andrew Eisenberg authored and GitHub committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA e8486b0View commit details -
Add some dependencies for uploading artifacts
Edoardo Pirovano authored and Edoardo Pirovano committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 0cbd4b5View commit details -
Merge branch 'main' into update-supported-enterprise-server-versions
Andrew Eisenberg authored and GitHub committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 739e14dView commit details -
Merge pull request #536 from github/aeisenberg/commander
Use commander preAction hook for setMode
Andrew Eisenberg authored and GitHub committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 1d05ad7View commit details -
Update supported GitHub Enterprise Server versions.
GitHub committedJun 2, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 2fee124View commit details
Commits on Jun 1, 2021
-
Use commander preAction hook for setMode
Hooks are new to commander v8. We can use hooks to ensure that `setMode` is called before every command is invoked.
Andrew Eisenberg committedJun 1, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 539d968View commit details -
Merge pull request #534 from github/aeisenberg/mergeback-fix
Fix the mergeback workflow
Andrew Eisenberg authored and GitHub committedJun 1, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 4b4a5eeView commit details
Commits on May 31, 2021
-
Andrew Eisenberg committed
May 31, 2021 Unverified
No user is associated with the committer email.Copy the full SHA f0e82b7View commit details -
Fix EOF newlines after
npm version patch
The removeNPMAbsolutePaths check requires no newlines at the end of the file. This ensures that the version update mimics the behavior.
Andrew Eisenberg committedMay 31, 2021 Unverified
No user is associated with the committer email.Copy the full SHA c02d8ccView commit details -
This should have happened in a mergeback PR, but the workflow to generate this was broken.
Andrew Eisenberg committedMay 31, 2021 Unverified
No user is associated with the committer email.Copy the full SHA a94829cView commit details -
Merge remote-tracking branch 'upstream/v1' into aeisenberg/mergeback-fix
Andrew Eisenberg committedMay 31, 2021 Copy the full SHA 7d701d2View commit details -
We need to tag and mergeback if the tag does _not_ already exist.
Andrew Eisenberg committedMay 31, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 981b5cbView commit details -
Merge pull request #516 from github/aeisenberg/user-agent
Send version and mode to code scanning via user agent
Andrew Eisenberg authored and GitHub committedMay 31, 2021 Copy the full SHA ca94508View commit details -
Use the version from package.json in the runner
Andrew Eisenberg committedMay 31, 2021 Copy the full SHA 1a4cdd3View commit details -
Use the version from package.json in the runner
Update the ql queries to account for change in how we look for runner Previously, we guarded blocks of code to be run by the runner or the action using if statements like this: ```js if (mode === "actions") ... ``` We are no longer doing this. And now, the `unguarded-action-lib.ql` query is out of date. This query checks that runner code does not unintentionally access actions-only methods in the libraries. With these changes, we now ensure that code scanning is happy.
Andrew Eisenberg committedMay 31, 2021 Copy the full SHA 4164096View commit details -
Send the version and mode with the user agent
This commit changes the way the action determines if running in action or runner mode. There is now an environment variable that is set at the beginning of the process and elsewhere in the process, we can check to see if the variable is set.
Andrew Eisenberg committedMay 31, 2021 Copy the full SHA 4758879View commit details -
Merge pull request #438 from okyanusoz/patch-1
Fix wording in README
Andrew Eisenberg authored and GitHub committedMay 31, 2021 Unverified
No user is associated with the committer email.Copy the full SHA fad7cc4View commit details -
Merge pull request #533 from github/update-v1.0.0-ff75ec7f
Merge main into v1
Andrew Eisenberg authored and GitHub committedMay 31, 2021 Unverified
No user is associated with the committer email.Copy the full SHA 4917d3cView commit details -
Unverified
No user is associated with the committer email.Copy the full SHA dd66f44View commit details -
github-actions[bot] committed
May 31, 2021 Copy the full SHA cf57db7View commit details
Commits on May 28, 2021
-
Merge branch 'main' into patch-1
Andrew Eisenberg authored and GitHub committedMay 28, 2021 -
Merge pull request #532 from github/henrymercer/analysis-summaries-cu…
…stom-queries Analyze: Log analysis summaries for custom queries
Henry Mercer authored and GitHub committedMay 28, 2021 -
Henry Mercer committed
May 28, 2021 -
Analyze: Log analysis summaries for custom queries
Henry Mercer committedMay 28, 2021
Commits on May 27, 2021
-
Merge pull request #510 from github/aeisenberg/update-changelog-on-re…
…lease Add release and mergeback workflows
Andrew Eisenberg authored and GitHub committedMay 27, 2021