Fix Jenkinsfile and tests

1) There's now a cleanup step before and after running the tests
2) Tests check their results more thoroughly
3) Until MariaDB is changed, a temporary solution for down-up issue is present

Jenkinsfile

@@ -50,7 +50,11 @@ pipeline {
                    sh 'midpoint/download-midpoint'
                    docker.withRegistry('https://registry.hub.docker.com/', "dockerhub-$maintainer") {
                       def baseImg = docker.build("$maintainer/$imagename", "--no-cache midpoint/midpoint-server")
-                      sh 'env NOCOLOR=true ./test.sh'
+                      try {
+                         sh 'env NOCOLOR=true ./test.sh'
+                      } finally {
+                         sh './cleanup.sh'
+                      }
                       baseImg.push("$tag")
                    }
                }

cleanup.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+midpoint/cleanup.sh

midpoint/cleanup.sh

@@ -0,0 +1,6 @@
+#!/bin/bash
+
+cd "$(dirname "$0")"
+echo "Cleaning up containers and images in `pwd`"
+
+docker-compose down -v

midpoint/docker-compose.yml

@@ -10,8 +10,8 @@ services:
     volumes:
      - midpoint_mysql:/var/lib/mysql
      - midpoint_data:/var/lib/mysqlmounted
-    environment:
-     - CREATE_NEW_DATABASE=if_needed
+#    environment:
+#     - CREATE_NEW_DATABASE=if_needed
 
   midpoint-server:
     build: ./midpoint-server/

midpoint/test.sh

@@ -5,6 +5,11 @@ trap 'exitcode=$? ; error "Exiting midpoint/test.sh because of an error ($exitco
 cd "$(dirname "$0")"
 . ../test/common.sh
 
+heading "Cleaning up containers and volumes if they exist"
+docker-compose down -v || true
+ok "Done"
+echo
+
 heading "Composing midPoint..."
 docker-compose up --no-start
 ok "midPoint composed OK"

midpoint/test/t110-get-administrator.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 
+trap 'exitcode=$? ; error "Exiting $0 because of an error ($exitcode) occurred" ; exit $exitcode' ERR
+. ../test/common.sh
+
 curl -k --user administrator:5ecr3t -H "Content-Type: application/xml" -X GET "https://localhost:8443/midpoint/ws/rest/users/00000000-0000-0000-0000-000000000002" >/tmp/admin.xml
 grep -q "<name>administrator</name>" </tmp/admin.xml || (echo "User 'administrator' was not found or not retrieved correctly" ; exit 1)
 rm /tmp/admin.xml

midpoint/test/t120-add-get-user.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-trap 'exitcode=$? ; error "Exiting because of an error ($exitcode) occurred" ; exit $exitcode' ERR
+trap 'exitcode=$? ; error "Exiting $0 because of an error ($exitcode) occurred" ; exit $exitcode' ERR
 . ../test/common.sh
 
 echo "Adding user 'test120'..."

midpoint/test/t200-stop-start.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-trap 'exitcode=$? ; error "Exiting because of an error ($exitcode) occurred" ; exit $exitcode' ERR
+trap 'exitcode=$? ; error "Exiting $0 because of an error ($exitcode) occurred" ; exit $exitcode' ERR
 . ../test/common.sh
 
 echo "Stopping containers..."

midpoint/test/t300-repository-preservation.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 USER=test300
-trap 'exitcode=$? ; error "Exiting because of an error ($exitcode) occurred" ; exit $exitcode' ERR
+trap 'exitcode=$? ; error "Exiting $0 because of an error ($exitcode) occurred" ; exit $exitcode' ERR
 . ../test/common.sh
 
 echo "Adding user '${USER}'..."