Create all required metadata for InCommon MDQ service #4
+351
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create new pipeline for MDQ and IdP-only aggregate * Move IdP-only aggregate to idps/all.xml * Rename mdq-new-* to mdq-combined-* * Reference JIRA issues in TODOs
iay
requested changes
Mar 7, 2019
There was a problem hiding this comment.
I'm pretty happy with the changes in the branch, the things I'd like to see changed are all pretty much peripheral:
- Changes to
build.xmlshould comply with existing conventions in the file:- no trailing spaces on lines (comment block above
inc.mdq.generate.all.localkey) - indentation via leading spaces, not via tabs (your changes sometimes do this, but sometimes don't, e.g. in
inc.mdq.generate.all.cloudhsm; this is problematic e.g., when doing comparisons in GitHub)
- no trailing spaces on lines (comment block above
- We should create a ticket in the GitLab milestone to link to this, so that we have a placeholder when we come to summarise the release. I will do this and add a mention of it in the squash commit when we merge this.
- I'd suggest moving things like
inc.mdq.generate.all.cloudhsmdown afterinc.mdq.generate.cloudhsmgiven that they are related.
|
I'm going to create a new pull request from my personal fork of this repository. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates two new build targets and pipelines: inc.mdq.generate.all.localkey (mdq-all-localkey.xml) and inc.mdq.generate.all.cloudhsm (mdq-all-cloudhsm.xml). Each target defines a privateKeyFactory bean (based on either PrivateKeyFactoryBean for local key, or CaviumPrivateKeyFactoryBean for CloudHSM), which it provides to a shared generateAll composite stage (mdq-all.xml).