Don't crash if we are unable to get a response from the feature-flag …

…endpoint.
github · Jul 18, 2022 · 01fa64c · 01fa64c
1 parent d8c9c72
commit 01fa64c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/lib/feature-flags.js b/lib/feature-flags.js
diff --git a/lib/feature-flags.js.map b/lib/feature-flags.js.map
diff --git a/src/feature-flags.ts b/src/feature-flags.ts
@@ -31,14 +31,21 @@ export class GitHubFeatureFlags implements FeatureFlags {
   ) {}
 
   async getValue(flag: FeatureFlag): Promise<boolean> {
-    const response = (await this.getApiResponse())[flag];
+    const response = await this.getApiResponse();
     if (response === undefined) {
+      this.logger.debug(
+        `No feature flags API response for ${flag}, considering it disabled.`
+      );
+      return false;
+    }
+    const flag_value = response[flag];
+    if (flag_value === undefined) {
       this.logger.debug(
         `Feature flag '${flag}' undefined in API response, considering it disabled.`
       );
       return false;
     }
-    return response;
+    return flag_value;
   }
 
   private async getApiResponse(): Promise<FeatureFlagsApiResponse> {