Skip to content

Commit

Permalink
#996: Fix python_setup/install_tool.sh
Browse files Browse the repository at this point in the history
When the script  executed on a runner which does not have python2, script incorrectly execute the code inside the if condition. This script runs using /bin/sh in Ubuntu and cause the problem. Fix for this issue to use different syntax in output redirection.

Issue is reproduced using running the job on ubunutu container. Fix also verified in the action https://github.com/cdivitotawela/codeql-issue/actions/runs/2038007502
  • Loading branch information
Chaminda Divitotawela authored and Chaminda Divitotawela committed Mar 27, 2022
1 parent 4d6e9c0 commit 077ec09
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python-setup/install_tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ python3 -m pip install --user 'virtualenv<20.11'
python3 -m pip install --user poetry!=1.0.10
python3 -m pip install --user pipenv

if command -v python2 &> /dev/null; then
if command -v python2 >/dev/null 2>&1; then
# Setup Python 2 dependency installation tools.
# The Ubuntu 20.04 GHA environment does not come with a Python 2 pip
curl --location --fail https://bootstrap.pypa.io/pip/2.7/get-pip.py | python2
Expand Down

0 comments on commit 077ec09

Please sign in to comment.