Merge pull request #312 from ericcornelissen/fix-minor-code-mistakes

Two minor code fixes
github · Nov 20, 2020 · 0a05e95 · 0a05e95
2 parents 31872f1 + a04d948
commit 0a05e95
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/.github/update-release-branch.py b/.github/update-release-branch.py
@@ -123,8 +123,8 @@ def get_pr_for_commit(repo, commit):
   if prs.totalCount > 0:
     # In the case that there are multiple PRs, return the earliest one
     prs = list(prs)
-    sorted(prs, key=lambda pr: int(pr.number))
-    return prs[0]
+    sorted_prs = sorted(prs, key=lambda pr: int(pr.number))
+    return sorted_prs[0]
   else:
     return None
 

diff --git a/lib/tracer-config.test.js b/lib/tracer-config.test.js
diff --git a/lib/tracer-config.test.js.map b/lib/tracer-config.test.js.map
diff --git a/src/tracer-config.test.ts b/src/tracer-config.test.ts
@@ -64,7 +64,6 @@ test("getTracerConfigForLanguage - existing / critical vars", async (t) => {
     process.env["SEMMLE_COPY_EXECUTABLES_ROOT"] = "abc";
     process.env["SEMMLE_DEPTRACE_SOCKET"] = "abc";
     process.env["SEMMLE_JAVA_TOOL_OPTIONS"] = "abc";
-    process.env["SEMMLE_DEPTRACE_SOCKET"] = "abc";
     process.env["CODEQL_VAR"] = "abc";
 
     // Now CodeQL returns all these variables, and one more, with different values