-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update unset environment variables PR check (#1269)
* Only test Java for CLI v2.5+ * Improve bash code style * Set Actions error messages Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
- Loading branch information
2 people
authored and
GitHub
committed
Sep 27, 2022
1 parent
314ede6
commit 1f0700d
Showing
4 changed files
with
184 additions
and
146 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # See `unset-environment-old-cli.yml` for reasoning behind the separate tests. | ||
| name: PR Check - Test unsetting environment variables for CLI version >= 2.5.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GO111MODULE: auto | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - releases/v1 | ||
| - releases/v2 | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review | ||
| workflow_dispatch: {} | ||
| jobs: | ||
| unset-environment: | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest | ||
| version: stable-20210809 | ||
| - os: ubuntu-latest | ||
| version: cached | ||
| - os: ubuntu-latest | ||
| version: latest | ||
| - os: ubuntu-latest | ||
| version: nightly-latest | ||
| name: Test unsetting environment variables | ||
| timeout-minutes: 45 | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v3 | ||
| - name: Prepare test | ||
| id: prepare-test | ||
| uses: ./.github/prepare-test | ||
| with: | ||
| version: ${{ matrix.version }} | ||
| - uses: ./../action/init | ||
| with: | ||
| db-location: ${{ runner.temp }}/customDbLocation | ||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
| env: | ||
| TEST_MODE: true | ||
| - name: Build code | ||
| shell: bash | ||
| run: env -i PATH="$PATH" HOME="$HOME" ./build.sh | ||
| - uses: ./../action/analyze | ||
| id: analysis | ||
| env: | ||
| TEST_MODE: true | ||
| - shell: bash | ||
| run: | | ||
| CPP_DB="${{ fromJson(steps.analysis.outputs.db-locations).cpp }}" | ||
| if [[ ! -d "$CPP_DB" ]] || [[ ! "$CPP_DB" == "${RUNNER_TEMP}/customDbLocation/cpp" ]]; then | ||
| echo "::error::Did not create a database for CPP, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/cpp' but actual was '${CPP_DB}'" | ||
| exit 1 | ||
| fi | ||
| CSHARP_DB="${{ fromJson(steps.analysis.outputs.db-locations).csharp }}" | ||
| if [[ ! -d "$CSHARP_DB" ]] || [[ ! "$CSHARP_DB" == "${RUNNER_TEMP}/customDbLocation/csharp" ]]; then | ||
| echo "::error::Did not create a database for C Sharp, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/csharp' but actual was '${CSHARP_DB}'" | ||
| exit 1 | ||
| fi | ||
| GO_DB="${{ fromJson(steps.analysis.outputs.db-locations).go }}" | ||
| if [[ ! -d "$GO_DB" ]] || [[ ! "$GO_DB" == "${RUNNER_TEMP}/customDbLocation/go" ]]; then | ||
| echo "::error::Did not create a database for Go, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/go' but actual was '${GO_DB}'" | ||
| exit 1 | ||
| fi | ||
| JAVA_DB="${{ fromJson(steps.analysis.outputs.db-locations).java }}" | ||
| if [[ ! -d "$JAVA_DB" ]] || [[ ! "$JAVA_DB" == "${RUNNER_TEMP}/customDbLocation/java" ]]; then | ||
| echo "::error::Did not create a database for Java, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/java' but actual was '${JAVA_DB}'" | ||
| exit 1 | ||
| fi | ||
| JAVASCRIPT_DB="${{ fromJson(steps.analysis.outputs.db-locations).javascript }}" | ||
| if [[ ! -d "$JAVASCRIPT_DB" ]] || [[ ! "$JAVASCRIPT_DB" == "${RUNNER_TEMP}/customDbLocation/javascript" ]]; then | ||
| echo "::error::Did not create a database for Javascript, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/javascript' but actual was '${JAVASCRIPT_DB}'" | ||
| exit 1 | ||
| fi | ||
| PYTHON_DB="${{ fromJson(steps.analysis.outputs.db-locations).python }}" | ||
| if [[ ! -d "$PYTHON_DB" ]] || [[ ! "$PYTHON_DB" == "${RUNNER_TEMP}/customDbLocation/python" ]]; then | ||
| echo "::error::Did not create a database for Python, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/python' but actual was '${PYTHON_DB}'" | ||
| exit 1 | ||
| fi | ||
| env: | ||
| INTERNAL_CODEQL_ACTION_DEBUG_LOC: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| # There was a bug, fixed in CLI v2.5.1, that didn't propagate environment | ||
| # variables that the Java tracer needed. Here we test all languages | ||
| # except Java for these CLI versions. In `unset-environment-new-cli.yml` | ||
| # we test all languages for recent CLI versions. | ||
| name: PR Check - Test unsetting environment variables for CLI version < 2.5.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GO111MODULE: auto | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - releases/v1 | ||
| - releases/v2 | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review | ||
| workflow_dispatch: {} | ||
| jobs: | ||
| unset-environment: | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest | ||
| version: stable-20210308 | ||
| - os: ubuntu-latest | ||
| version: stable-20210319 | ||
| name: Test unsetting environment variables | ||
| timeout-minutes: 45 | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v3 | ||
| - name: Prepare test | ||
| id: prepare-test | ||
| uses: ./.github/prepare-test | ||
| with: | ||
| version: ${{ matrix.version }} | ||
| - uses: ./../action/init | ||
| with: | ||
| languages: csharp,cpp,go,javascript,python | ||
| db-location: ${{ runner.temp }}/customDbLocation | ||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
| env: | ||
| TEST_MODE: true | ||
| - name: Build code | ||
| shell: bash | ||
| run: env -i PATH="$PATH" HOME="$HOME" ./build.sh | ||
| - uses: ./../action/analyze | ||
| id: analysis | ||
| env: | ||
| TEST_MODE: true | ||
| - shell: bash | ||
| run: | | ||
| CPP_DB="${{ fromJson(steps.analysis.outputs.db-locations).cpp }}" | ||
| if [[ ! -d "$CPP_DB" ]] || [[ ! "$CPP_DB" == "${RUNNER_TEMP}/customDbLocation/cpp" ]]; then | ||
| echo "::error::Did not create a database for CPP, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/cpp' but actual was '${CPP_DB}'" | ||
| exit 1 | ||
| fi | ||
| CSHARP_DB="${{ fromJson(steps.analysis.outputs.db-locations).csharp }}" | ||
| if [[ ! -d "$CSHARP_DB" ]] || [[ ! "$CSHARP_DB" == "${RUNNER_TEMP}/customDbLocation/csharp" ]]; then | ||
| echo "::error::Did not create a database for C Sharp, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/csharp' but actual was '${CSHARP_DB}'" | ||
| exit 1 | ||
| fi | ||
| GO_DB="${{ fromJson(steps.analysis.outputs.db-locations).go }}" | ||
| if [[ ! -d "$GO_DB" ]] || [[ ! "$GO_DB" == "${RUNNER_TEMP}/customDbLocation/go" ]]; then | ||
| echo "::error::Did not create a database for Go, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/go' but actual was '${GO_DB}'" | ||
| exit 1 | ||
| fi | ||
| JAVASCRIPT_DB="${{ fromJson(steps.analysis.outputs.db-locations).javascript }}" | ||
| if [[ ! -d "$JAVASCRIPT_DB" ]] || [[ ! "$JAVASCRIPT_DB" == "${RUNNER_TEMP}/customDbLocation/javascript" ]]; then | ||
| echo "::error::Did not create a database for Javascript, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/javascript' but actual was '${JAVASCRIPT_DB}'" | ||
| exit 1 | ||
| fi | ||
| PYTHON_DB="${{ fromJson(steps.analysis.outputs.db-locations).python }}" | ||
| if [[ ! -d "$PYTHON_DB" ]] || [[ ! "$PYTHON_DB" == "${RUNNER_TEMP}/customDbLocation/python" ]]; then | ||
| echo "::error::Did not create a database for Python, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/python' but actual was '${PYTHON_DB}'" | ||
| exit 1 | ||
| fi | ||
| env: | ||
| INTERNAL_CODEQL_ACTION_DEBUG_LOC: true |
This file was deleted.
Oops, something went wrong.