Remove unnecessary type assertions

github · Jun 10, 2021 · 20aafcd · 20aafcd
1 parent 6a1c070
commit 20aafcd
Showing 8 changed files with 23 additions and 11 deletions.
diff --git a/lib/analyze.js b/lib/analyze.js
diff --git a/lib/analyze.js.map b/lib/analyze.js.map
diff --git a/lib/config-utils.js b/lib/config-utils.js
diff --git a/lib/config-utils.js.map b/lib/config-utils.js.map
diff --git a/lib/tracer-config.test.js.map b/lib/tracer-config.test.js.map
diff --git a/src/analyze.ts b/src/analyze.ts
@@ -191,6 +191,12 @@ export async function runQueries(
 
     try {
       if (hasPackWithCustomQueries) {
+        logger.info("*************");
+        logger.info(
+          "Performing analysis with custom QL Packs. QL Packs are an experimental feature."
+        );
+        logger.info("And should not be used in production yet.");
+        logger.info("*************");
         logger.startGroup(`Downloading custom packs for ${language}`);
 
         const codeql = getCodeQL(config.codeQLCmd);
@@ -338,7 +344,7 @@ function packWithVersionToQuerySuiteEntry(
 ): string {
   let text = `- qlpack: ${pack.packName}`;
   if (pack.version) {
-    text += `${"\n"}  version: ${pack.version}`;
+    text += `\n  version: ${pack.version}`;
   }
   return text;
 }

diff --git a/src/config-utils.ts b/src/config-utils.ts
@@ -845,7 +845,7 @@ export async function getDefaultConfig(
     queries,
     pathsIgnore: [],
     paths: [],
-    packs: {} as Record<Language, PackWithVersion[]>,
+    packs: {},
     originalUserInput: {},
     tempDir,
     toolCacheDir,
@@ -942,10 +942,11 @@ async function loadConfig(
     shouldAddConfigFileQueries(queriesInput) &&
     QUERIES_PROPERTY in parsedYAML
   ) {
-    if (!Array.isArray(parsedYAML[QUERIES_PROPERTY])) {
+    const queriesArr = parsedYAML[QUERIES_PROPERTY];
+    if (!Array.isArray(queriesArr)) {
       throw new Error(getQueriesInvalid(configFile));
     }
-    for (const query of parsedYAML[QUERIES_PROPERTY]!) {
+    for (const query of queriesArr) {
       if (
         !(QUERIES_USES_PROPERTY in query) ||
         typeof query[QUERIES_USES_PROPERTY] !== "string"

diff --git a/src/tracer-config.test.ts b/src/tracer-config.test.ts
@@ -28,7 +28,7 @@ function getTestConfig(tmpDir: string): configUtils.Config {
     codeQLCmd: "",
     gitHubVersion: { type: util.GitHubVariant.DOTCOM } as util.GitHubVersion,
     dbLocation: path.resolve(tmpDir, "codeql_databases"),
-    packs: {} as configUtils.Packs,
+    packs: {},
   };
 }