Merge pull request #778 from github/aeisenberg/fix-python-tests

Fix failing python tests
github · Oct 15, 2021 · 286a237 · 286a237
2 parents 1ebb0a0 + 43ea2ce
commit 286a237
Show file tree

Hide file tree

Showing 15 changed files with 340 additions and 41 deletions.
diff --git a/.github/workflows/python-deps.yml b/.github/workflows/python-deps.yml
@@ -58,7 +58,7 @@ jobs:
 
     - name: Verify packages installed
       run: |
-        $GITHUB_WORKSPACE/python-setup/tests/check_requests_123.sh ${PYTHON_VERSION}
+        $GITHUB_WORKSPACE/python-setup/tests/check_requests_2_26_0.sh ${PYTHON_VERSION}
 
   # This one shouldn't fail, but also won't install packages
   test-setup-python-scripts-non-standard-location:
@@ -123,6 +123,10 @@ jobs:
     # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
     - uses: actions/checkout@v2
 
+    - uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+
     - name: Initialize CodeQL
       uses: ./init
       with:
@@ -149,5 +153,5 @@ jobs:
 
     - name: Verify packages installed
       run: |
-        $cmd = $Env:GITHUB_WORKSPACE + "\\python-setup\\tests\\check_requests_123.ps1"
+        $cmd = $Env:GITHUB_WORKSPACE + "\\python-setup\\tests\\check_requests_2_26_0.ps1"
         powershell -File $cmd $Env:PYTHON_VERSION
diff --git a/python-setup/tests/check_requests_123.ps1 → python-setup/tests/check_requests_2_26_0.ps1 b/python-setup/tests/check_requests_123.ps1 → python-setup/tests/check_requests_2_26_0.ps1
@@ -18,11 +18,11 @@ $env:PYTHONPATH=$FOUND_PYTHONPATH
 
 $INSTALLED_REQUESTS_VERSION = (py -3 -c "import requests; print(requests.__version__)")
 
-$EXPECTED_REQUESTS="1.2.3"
+$EXPECTED_REQUESTS="2.26.0"
 
 if ($INSTALLED_REQUESTS_VERSION -ne $EXPECTED_REQUESTS) {
     write-host "Using $FOUND_PYTHONPATH as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, but expected $EXPECTED_REQUESTS"
     exit 1
 } else {
     write-host "Using $FOUND_PYTHONPATH as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, which was expected"
-}
+}
diff --git a/python-setup/tests/check_requests_123.sh → python-setup/tests/check_requests_2_26_0.sh b/python-setup/tests/check_requests_123.sh → python-setup/tests/check_requests_2_26_0.sh
@@ -22,11 +22,11 @@ PYTHON_EXE="python${EXPECTED_VERSION}"
 
 INSTALLED_REQUESTS_VERSION=$(PYTHONPATH="${FOUND_PYTHONPATH}" "${PYTHON_EXE}" -c 'import requests; print(requests.__version__)')
 
-EXPECTED_REQUESTS="1.2.3"
+EXPECTED_REQUESTS="2.26.0"
 
 if [[ "$INSTALLED_REQUESTS_VERSION" != "$EXPECTED_REQUESTS" ]]; then
     echo "Using ${FOUND_PYTHONPATH} as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, but expected $EXPECTED_REQUESTS"
     exit 1
 else
     echo "Using ${FOUND_PYTHONPATH} as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, which was expected"
-fi
+fi
diff --git a/python-setup/tests/pipenv/python-3.8/Pipfile.lock b/python-setup/tests/pipenv/python-3.8/Pipfile.lock
diff --git a/python-setup/tests/pipenv/requests-2/Pipfile.lock b/python-setup/tests/pipenv/requests-2/Pipfile.lock
diff --git a/python-setup/tests/pipenv/requests-3/Pipfile.lock b/python-setup/tests/pipenv/requests-3/Pipfile.lock
diff --git a/python-setup/tests/poetry/python-3.8/poetry.lock b/python-setup/tests/poetry/python-3.8/poetry.lock