Merge pull request #817 from edoardopirovano/respect-ld-preload

Respect value of `LD_PRELOAD` given by the CLI
github · Nov 16, 2021 · 2ecc17d · 2ecc17d
2 parents 2803f4a + 9b506fe
commit 2ecc17d
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 28 deletions.
diff --git a/lib/tracer-config.js b/lib/tracer-config.js
diff --git a/lib/tracer-config.js.map b/lib/tracer-config.js.map
diff --git a/src/tracer-config.ts b/src/tracer-config.ts
@@ -212,25 +212,25 @@ export async function getCombinedTracerConfig(
       );
     }
     mainTracerConfig = concatTracerConfigs(tracedLanguageConfigs, config);
-  }
 
-  // Add a couple more variables
-  mainTracerConfig.env["ODASA_TRACER_CONFIGURATION"] = mainTracerConfig.spec;
-  const codeQLDir = path.dirname(codeql.getPath());
-  if (process.platform === "darwin") {
-    mainTracerConfig.env["DYLD_INSERT_LIBRARIES"] = path.join(
-      codeQLDir,
-      "tools",
-      "osx64",
-      "libtrace.dylib"
-    );
-  } else if (process.platform !== "win32") {
-    mainTracerConfig.env["LD_PRELOAD"] = path.join(
-      codeQLDir,
-      "tools",
-      "linux64",
-      "${LIB}trace.so"
-    );
+    // Add a couple more variables
+    mainTracerConfig.env["ODASA_TRACER_CONFIGURATION"] = mainTracerConfig.spec;
+    const codeQLDir = path.dirname(codeql.getPath());
+    if (process.platform === "darwin") {
+      mainTracerConfig.env["DYLD_INSERT_LIBRARIES"] = path.join(
+        codeQLDir,
+        "tools",
+        "osx64",
+        "libtrace.dylib"
+      );
+    } else if (process.platform !== "win32") {
+      mainTracerConfig.env["LD_PRELOAD"] = path.join(
+        codeQLDir,
+        "tools",
+        "linux64",
+        "${LIB}trace.so"
+      );
+    }
   }
 
   // On macos it's necessary to prefix the build command with the runner executable