Use Object.entries() instead of checking hasOwnProperty

Co-authored-by: Robert <robertbrignull@github.com>
github · Jun 19, 2020 · 34c941d · 34c941d
1 parent 5eccb79
commit 34c941d
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/src/setup-tools.test.ts b/src/setup-tools.test.ts
@@ -49,18 +49,14 @@ test('parse codeql bundle url version', t => {
         '1.2.3-beta.1': '1.2.3-beta.1',
     };
 
-    for (const version in tests) {
-        if (tests.hasOwnProperty(version)) {
-
-            const expectedVersion = tests[version];
-            const url = `https://github.com/.../codeql-bundle-${version}/...`;
-
-            try {
-                const parsedVersion = setupTools.getCodeQLURLVersion(url);
-                t.deepEqual(parsedVersion, expectedVersion);
-            } catch (e) {
-                t.fail(e.message);
-            }
+    for (const [version, expectedVersion] of Object.entries(tests)) {
+        const url = `https://github.com/.../codeql-bundle-${version}/...`;
+
+        try {
+            const parsedVersion = setupTools.getCodeQLURLVersion(url);
+            t.deepEqual(parsedVersion, expectedVersion);
+        } catch (e) {
+            t.fail(e.message);
         }
     }
 });