Move formatGitHubVersion into util.test.ts

github · Apr 28, 2022 · 35ef6a2 · 35ef6a2
1 parent 5227afa
commit 35ef6a2
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 31 deletions.
diff --git a/lib/util.js b/lib/util.js
diff --git a/lib/util.js.map b/lib/util.js.map
diff --git a/lib/util.test.js b/lib/util.test.js
diff --git a/lib/util.test.js.map b/lib/util.test.js.map
diff --git a/src/util.test.ts b/src/util.test.ts
@@ -394,6 +394,19 @@ test("isGitHubGhesVersionBelow", async (t) => {
   );
 });
 
+function formatGitHubVersion(version: util.GitHubVersion): string {
+  switch (version.type) {
+    case util.GitHubVariant.DOTCOM:
+      return "dotcom";
+    case util.GitHubVariant.GHAE:
+      return "GHAE";
+    case util.GitHubVariant.GHES:
+      return `GHES ${version.version}`;
+    default:
+      util.assertNever(version);
+  }
+}
+
 const CHECK_ACTION_VERSION_TESTS: Array<[string, util.GitHubVersion, boolean]> =
   [
     ["1.2.1", { type: util.GitHubVariant.DOTCOM }, true],
@@ -416,7 +429,7 @@ for (const [
   const reportWarningDescription = shouldReportWarning
     ? "reports warning"
     : "doesn't report warning";
-  const versionsDescription = `CodeQL Action version ${version} and GitHub version ${util.formatGitHubVersion(
+  const versionsDescription = `CodeQL Action version ${version} and GitHub version ${formatGitHubVersion(
     githubVersion
   )}`;
   test(`checkActionVersion ${reportWarningDescription} for ${versionsDescription}`, async (t) => {

diff --git a/src/util.ts b/src/util.ts
@@ -738,16 +738,3 @@ export async function checkActionVersion(version: string) {
     }
   }
 }
-
-export function formatGitHubVersion(version: GitHubVersion): string {
-  switch (version.type) {
-    case GitHubVariant.DOTCOM:
-      return "dotcom";
-    case GitHubVariant.GHAE:
-      return "GHAE";
-    case GitHubVariant.GHES:
-      return `GHES ${version.version}`;
-    default:
-      assertNever(version);
-  }
-}