Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #1485 from github/aeisenberg/comitoid-message
Hide error message and stack for non-error
Andrew Eisenberg authored and GitHub committed Jan 18, 2023

Unverified

No user is associated with the committer email.
2 parents 32be38e + e6e3bf4 commit 40cfcb0
Showing 4 changed files with 10 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
@@ -3,6 +3,9 @@
## [UNRELEASED]

- Python automatic dependency installation will no longer fail for projects using Poetry that specify `virtualenvs.options.no-pip = true` in their `poetry.toml`. [#1431](https://github.com/github/codeql-action/pull/1431).
- Avoid printing a stack trace and error message when the action fails to find the SHA at the
current directory. This will happen in several non-error states and so we now avoid cluttering the
log with this message. [#1485](https://github.com/github/codeql-action/pull/1485)

## 2.1.38 - 12 Jan 2023

5 changes: 3 additions & 2 deletions lib/actions-util.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/actions-util.js.map
5 changes: 3 additions & 2 deletions src/actions-util.ts
@@ -88,9 +88,10 @@ export const getCommitOid = async function (
return commitOid.trim();
} catch (e) {
core.info(
`Failed to call git to get current commit. Continuing with data from environment or input: ${e}`
"Could not determine current commit SHA using git. Continuing with data from user input or environment."
);
core.info((e as Error).stack || "NO STACK");
core.debug(`Reason: ${(e as Error).message}`);
core.debug((e as Error).stack || "NO STACK");
return getOptionalInput("sha") || getRequiredEnvParam("GITHUB_SHA");
}
};

0 comments on commit 40cfcb0

Please sign in to comment.