Re-throw errors

github · Aug 12, 2020 · 4b56177 · 4b56177
1 parent 150e07f
commit 4b56177
Showing 6 changed files with 15 additions and 6 deletions.
diff --git a/lib/cli.js b/lib/cli.js
diff --git a/lib/cli.js.map b/lib/cli.js.map
diff --git a/lib/upload-lib.js b/lib/upload-lib.js
diff --git a/lib/upload-lib.js.map b/lib/upload-lib.js.map
diff --git a/src/cli.ts b/src/cli.ts
@@ -40,6 +40,8 @@ function parseGithubApiUrl(inputUrl: string): string {
   }
 }
 
+const logger = getCLILogger();
+
 program
   .command('upload')
   .description('Uploads a SARIF file, or all SARIF files from a directory, to code scanning')
@@ -51,7 +53,6 @@ program
   .requiredOption('--github-auth <auth>', 'GitHub Apps token, or of the form "username:token" if using a personal access token')
   .option('--checkout-path <path>', 'Checkout path (default: current working directory)')
   .action(async (cmd: UploadArgs) => {
-    const logger = getCLILogger();
     try {
       await upload_lib.upload(
         cmd.sarifFile,
@@ -68,8 +69,9 @@ program
         'cli',
         logger);
     } catch (e) {
-      logger.error("Upload failed");
+      logger.error('Upload failed');
       logger.error(e);
+      process.exitCode = 1;
     }
   });
 

diff --git a/src/upload-lib.ts b/src/upload-lib.ts
@@ -139,6 +139,9 @@ export async function upload(
   logger: Logger): Promise<UploadStatusReport> {
 
   const sarifFiles: string[] = [];
+  if (!fs.existsSync(sarifPath)) {
+    throw new Error(`Path does not exist: ${sarifPath}`);
+  }
   if (fs.lstatSync(sarifPath).isDirectory()) {
     fs.readdirSync(sarifPath)
       .filter(f => f.endsWith(".sarif"))