move maxThreads outside of loop

github · Aug 17, 2020 · 5eb3736 · 5eb3736
1 parent aaeb975
commit 5eb3736
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/util.js b/lib/util.js
diff --git a/lib/util.js.map b/lib/util.js.map
diff --git a/src/util.ts b/src/util.ts
@@ -385,12 +385,12 @@ export function getMemoryFlag(): string {
 export function getThreadsFlag(): string {
   let numThreads: number;
   const numThreadsString = core.getInput("threads");
+  const maxThreads = os.cpus().length;
   if (numThreadsString) {
     numThreads = Number(numThreadsString);
     if (Number.isNaN(numThreads)) {
       throw new Error(`Invalid threads setting "${numThreadsString}", specified.`);
     }
-    const maxThreads = os.cpus().length;
     if (numThreads > maxThreads) {
       core.info(`Clamping desired number of threads (${numThreads}) to max available (${maxThreads}).`);
       numThreads = maxThreads;
@@ -402,7 +402,7 @@ export function getThreadsFlag(): string {
     }
   } else {
     // Default to using all threads
-    numThreads = os.cpus().length;
+    numThreads = maxThreads;
   }
   return `--threads=${numThreads}`;
 }