Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Marco Gario  <marcogario@github.com>
  • Loading branch information
2 people authored and GitHub committed Sep 24, 2020
1 parent 3495596 commit 6645c55
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions python-setup/extractor_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ def suppress_stdout_stderr():


def get_extractor_version(codeql_base_dir: str, quiet: bool = True) -> int:

extractor_dir = os.path.join(codeql_base_dir, 'python', 'tools')
sys.path = [extractor_dir] + sys.path

Expand All @@ -50,4 +49,4 @@ def get_extractor_version(codeql_base_dir: str, quiet: bool = True) -> int:
if __name__ == "__main__":
codeql_base_dir = sys.argv[1]
version = get_extractor_version(codeql_base_dir)
print('{!r}'.format(version))
print('{!r}'.format(version))
2 changes: 1 addition & 1 deletion python-setup/install_tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ python3 -m pip install --user virtualenv
# venv is required for installation of poetry or pipenv (I forgot which)
sudo apt-get install -y python3-venv

# We're install poetry with pip instead of the recommended way, since the recommended way
# We install poetry with pip instead of the recommended way, since the recommended way
# caused some problem since `poetry run` gives output like:
#
# /root/.poetry/lib/poetry/_vendor/py2.7/subprocess32.py:149: RuntimeWarning: The _posixsubprocess module is not being used. Child process reliability may suffer if your program uses threads.
Expand Down

0 comments on commit 6645c55

Please sign in to comment.