Work around test -v not being available in Mac Bash

github · Sep 1, 2022 · 6699d47 · 6699d47
1 parent 1d311fe
commit 6699d47
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/__go-reconciled-tracing-custom-build-steps.yml b/.github/workflows/__go-reconciled-tracing-custom-build-steps.yml
diff --git a/pr-checks/checks/go-reconciled-tracing-custom-build-steps.yml b/pr-checks/checks/go-reconciled-tracing-custom-build-steps.yml
@@ -21,7 +21,10 @@ steps:
       TEST_MODE: true
   - shell: bash
     run: |
-      if [[ -v CODEQL_ACTION_DID_AUTOBUILD_GOLANG ]]; then
+      # Once we start running Bash 4.2 in all environments, we can replace the
+      # `! -z` flag with the more elegant `-v` which confirms that the variable
+      # is actually unset and not potentially set to a blank value.
+      if [[ ! -z "${CODEQL_ACTION_DID_AUTOBUILD_GOLANG}" ]]; then
         echo "Expected the Go autobuilder not to be run, but the" \
           "CODEQL_ACTION_DID_AUTOBUILD_GOLANG environment variable was set."
         exit 1