Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Add more granular exception handling
Simon Engledew committed Jan 22, 2021

Unverified

No user is associated with the committer email.
1 parent 8a9922d commit 6be1f5c
Showing 3 changed files with 38 additions and 22 deletions.
29 changes: 19 additions & 10 deletions lib/actions-util.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/actions-util.js.map
29 changes: 18 additions & 11 deletions src/actions-util.ts
@@ -317,23 +317,30 @@ export function getWorkflowErrors(doc: Workflow): CodedError[] {
}

export async function validateWorkflow(): Promise<undefined | string> {
let workflow: Workflow;
try {
const workflow = await getWorkflow();
workflow = await getWorkflow();
} catch (e) {
return `error: getWorkflow() failed: ${e.toString()}`;
}
let workflowErrors: CodedError[];
try {
workflowErrors = getWorkflowErrors(workflow);
} catch (e) {
return `error: getWorkflowErrors() failed: ${e.toString()}`;
}

if (workflowErrors.length > 0) {
let message: string;
try {
const workflowErrors = getWorkflowErrors(workflow);

if (workflowErrors.length > 0) {
core.warning(formatWorkflowErrors(workflowErrors));
}

return `warning: ${formatWorkflowCause(workflowErrors)}`;
message = formatWorkflowErrors(workflowErrors);
} catch (e) {
return `error: getWorkflowErrors() failed: ${e.toString()}`;
return `error: formatWorkflowErrors() failed: ${e.toString()}`;
}
} catch (e) {
return `error: getWorkflow() failed: ${e.toString()}`;
core.warning(message);
}

return `warning: ${formatWorkflowCause(workflowErrors)}`;
}

export function formatWorkflowErrors(errors: CodedError[]): string {

0 comments on commit 6be1f5c

Please sign in to comment.