Add a default value for wait-for-processing.

github · Nov 17, 2021 · 823bb21 · 823bb21
1 parent 49fc4c9
commit 823bb21
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/analyze/action.yml b/analyze/action.yml
@@ -54,7 +54,8 @@ inputs:
     default: "true"
   wait-for-processing:
     description: If true, the Action will wait for the uploaded SARIF to be processed before completing.
-    required: false
+    required: true
+    default: "false"
   token:
     default: ${{ github.token }}
   matrix:

diff --git a/lib/upload-lib.js b/lib/upload-lib.js
diff --git a/src/upload-lib.ts b/src/upload-lib.ts
@@ -161,7 +161,7 @@ export async function uploadFromActions(
     actionsUtil.getWorkflowRunID(),
     actionsUtil.getRequiredInput("checkout_path"),
     actionsUtil.getRequiredInput("matrix"),
-    actionsUtil.getOptionalInput("wait-for-processing") === "true",
+    actionsUtil.getRequiredInput("wait-for-processing") === "true",
     gitHubVersion,
     apiDetails,
     logger

diff --git a/upload-sarif/action.yml b/upload-sarif/action.yml
@@ -6,7 +6,7 @@ inputs:
     description: |
       The SARIF file or directory of SARIF files to be uploaded to GitHub code scanning.
       See https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#uploading-a-code-scanning-analysis-with-github-actions
-      for information on the maximum number of results and maximum file size supported by code scanning. 
+      for information on the maximum number of results and maximum file size supported by code scanning.
     required: false
     default: '../results'
   checkout_path:
@@ -22,7 +22,8 @@ inputs:
     required: false
   wait-for-processing:
     description: If true, the Action will wait for the uploaded SARIF to be processed before completing.
-    required: false
+    required: true
+    default: "false"
 runs:
   using: 'node12'
   main: '../lib/upload-sarif-action.js'