Skip to content

Commit

Permalink
Document use of redundant feature flag API call
Browse files Browse the repository at this point in the history
  • Loading branch information
Henry Mercer committed Jan 6, 2022
1 parent efded22 commit 9de1702
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions lib/analyze-action.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/analyze-action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ async function run() {
repositoryNwo,
logger
);
// We currently perform an API request in both the `init` and `analyze` Actions to determine
// what feature flags are enabled. At the time of writing, this redundant API call is acceptable
// to us, but if we wanted to avoid it, we could do so by serializing the feature flags as part
// of the config file.
void featureFlags.preloadFeatureFlags();

await runFinalize(outputDir, threads, memory, config, logger);
Expand Down

0 comments on commit 9de1702

Please sign in to comment.