Handle the case where branches may be strings, including "*"

github · Dec 1, 2020 · ac1c081 · ac1c081
1 parent c6dbd5a
commit ac1c081
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 13 deletions.
diff --git a/lib/actions-util.js b/lib/actions-util.js
diff --git a/lib/actions-util.js.map b/lib/actions-util.js.map
diff --git a/lib/actions-util.test.js b/lib/actions-util.test.js
diff --git a/lib/actions-util.test.js.map b/lib/actions-util.test.js.map
diff --git a/src/actions-util.test.ts b/src/actions-util.test.ts
@@ -143,6 +143,22 @@ test("validateWorkflow() when on.push is a correct object", (t) => {
   t.deepEqual(errors.length, 0);
 });
 
+test("validateWorkflow() when on.pull_requests is a string", (t) => {
+  const errors = actionsutil.validateWorkflow({
+    on: { push: { branches: ["main"] }, pull_request: { branches: "*" } },
+  });
+
+  t.deepEqual(errors, [actionsutil.WorkflowErrors.MismatchedBranches]);
+});
+
+test("validateWorkflow() when on.pull_requests is a string and correct", (t) => {
+  const errors = actionsutil.validateWorkflow({
+    on: { push: { branches: "*" }, pull_request: { branches: "*" } },
+  });
+
+  t.deepEqual(errors, []);
+});
+
 test("validateWorkflow() when on.push is correct with empty objects", (t) => {
   const errors = actionsutil.validateWorkflow({
     on: { push: undefined, pull_request: undefined },