Ensure destination directory exists when streaming extraction

github · Dec 3, 2024 · b2a4442 · b2a4442
1 parent d5bcf48
commit b2a4442
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 4 deletions.
diff --git a/lib/tar.js b/lib/tar.js
diff --git a/lib/tar.js.map b/lib/tar.js.map
diff --git a/lib/tools-download.js b/lib/tools-download.js
diff --git a/lib/tools-download.js.map b/lib/tools-download.js.map
diff --git a/src/tar.ts b/src/tar.ts
@@ -175,7 +175,9 @@ export async function extractTarZst(
 
       if (tar instanceof stream.Readable) {
         tar.pipe(tarProcess.stdin).on("error", (err) => {
-          reject(new Error(`Error while piping tar stream: ${err}`));
+          reject(
+            new Error(`Error while downloading and extracting tar: ${err}`),
+          );
         });
       }
 

diff --git a/src/tools-download.ts b/src/tools-download.ts
@@ -183,6 +183,10 @@ async function downloadAndExtractZstdWithStreaming(
   tarVersion: tar.TarVersion,
   logger: Logger,
 ): Promise<void> {
+  // Ensure destination exists
+  fs.mkdirSync(dest, { recursive: true });
+
+  // Add User-Agent header and Authorization header if provided.
   headers = Object.assign(
     { "User-Agent": "CodeQL Action" },
     authorization ? { authorization } : {},
@@ -193,6 +197,7 @@ async function downloadAndExtractZstdWithStreaming(
       codeqlURL,
       {
         headers,
+        // Increase the high water mark to improve performance.
         highWaterMark: STREAMING_HIGH_WATERMARK_BYTES,
       } as unknown as RequestOptions,
       (r) => resolve(r),