Merge pull request #232 from miqh/fix/204

Resolve violations of no-throw-literal lint
github · Sep 28, 2020 · bcf29b3 · bcf29b3
2 parents f2e557e + 476bf86
commit bcf29b3
Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -48,7 +48,6 @@
             "github/no-then": "off",
             "import/no-extraneous-dependencies": "off",
             "no-shadow": "off",
-            "no-throw-literal": "off",
             "no-useless-escape": "off",
             "sort-imports": "off"
         }

diff --git a/lib/upload-lib.js b/lib/upload-lib.js
diff --git a/lib/upload-lib.js.map b/lib/upload-lib.js.map
diff --git a/src/upload-lib.ts b/src/upload-lib.ts
@@ -26,7 +26,9 @@ export function combineSarifFiles(sarifFiles: string[]): string {
     if (combinedSarif.version === null) {
       combinedSarif.version = sarifObject.version;
     } else if (combinedSarif.version !== sarifObject.version) {
-      throw `Different SARIF versions encountered: ${combinedSarif.version} and ${sarifObject.version}`;
+      throw new Error(
+        `Different SARIF versions encountered: ${combinedSarif.version} and ${sarifObject.version}`
+      );
     }
 
     combinedSarif.runs.push(...sarifObject.runs);