Don't re-retrieve GitHub version when already have it

https://github.com/github/codeql-action/commit/54e0c67332afd925b1a71c346726efc5c788b260#r45693026 https://github.com/github/codeql-action/commit/54e0c67332afd925b1a71c346726efc5c788b260#r45693030
github · Jan 6, 2021 · c7275a7 · c7275a7
1 parent 023add5
commit c7275a7
Showing 6 changed files with 6 additions and 10 deletions.
diff --git a/lib/analyze-action.js b/lib/analyze-action.js
diff --git a/lib/analyze-action.js.map b/lib/analyze-action.js.map
diff --git a/lib/runner.js b/lib/runner.js
diff --git a/lib/runner.js.map b/lib/runner.js.map
diff --git a/src/analyze-action.ts b/src/analyze-action.ts
@@ -84,7 +84,6 @@ async function run() {
     );
 
     if (actionsUtil.getRequiredInput("upload") === "true") {
-      const gitHubVersion = await util.getGitHubVersion(apiDetails);
       const uploadStats = await upload_lib.uploadFromActions(
         outputDir,
         parseRepositoryNwo(
@@ -97,7 +96,7 @@ async function run() {
         actionsUtil.getWorkflowRunID(),
         actionsUtil.getRequiredInput("checkout_path"),
         actionsUtil.getRequiredInput("matrix"),
-        gitHubVersion,
+        config.gitHubVersion,
         apiDetails,
         logger
       );

diff --git a/src/runner.ts b/src/runner.ts
@@ -392,14 +392,13 @@ program
         return;
       }
 
-      const gitHubVersion = await getGitHubVersion(apiDetails);
       await upload_lib.uploadFromRunner(
         outputDir,
         parseRepositoryNwo(cmd.repository),
         cmd.commit,
         parseRef(cmd.ref),
         cmd.checkoutPath || process.cwd(),
-        gitHubVersion,
+        config.gitHubVersion,
         apiDetails,
         logger
       );