Use .push rather than .concat

github · Sep 11, 2024 · d4bfd40 · d4bfd40
1 parent 82ce313
commit d4bfd40
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/lib/debug-artifacts.js b/lib/debug-artifacts.js
diff --git a/lib/debug-artifacts.js.map b/lib/debug-artifacts.js.map
diff --git a/src/debug-artifacts.ts b/src/debug-artifacts.ts
@@ -28,7 +28,7 @@ export async function uploadAllAvailableDebugArtifacts(
   config: Config,
   logger: Logger,
 ) {
-  let filesToUpload: string[] = [];
+  const filesToUpload: string[] = [];
 
   const analyzeActionOutputDir = process.env[EnvVar.SARIF_RESULTS_OUTPUT_DIR];
   for (const lang of config.languages) {
@@ -46,15 +46,15 @@ export async function uploadAllAvailableDebugArtifacts(
           `${lang}.sarif`,
         );
         fs.renameSync(sarifFile, sarifInDbLocation);
-        filesToUpload = filesToUpload.concat(sarifInDbLocation);
+        filesToUpload.push(sarifInDbLocation);
       }
     }
 
     // Add any log files
     const databaseDirectory = getCodeQLDatabasePath(config, lang);
     const logsDirectory = path.resolve(databaseDirectory, "log");
     if (doesDirectoryExist(logsDirectory)) {
-      filesToUpload = filesToUpload.concat(listFolder(logsDirectory));
+      filesToUpload.push(...listFolder(logsDirectory));
     }
 
     // Multilanguage tracing: there are additional logs in the root of the cluster
@@ -63,9 +63,7 @@ export async function uploadAllAvailableDebugArtifacts(
       "log",
     );
     if (doesDirectoryExist(multiLanguageTracingLogsDirectory)) {
-      filesToUpload = filesToUpload.concat(
-        listFolder(multiLanguageTracingLogsDirectory),
-      );
+      filesToUpload.push(...listFolder(multiLanguageTracingLogsDirectory));
     }
 
     // Add database bundle
@@ -75,7 +73,7 @@ export async function uploadAllAvailableDebugArtifacts(
     } else {
       databaseBundlePath = await createDatabaseBundleCli(config, lang);
     }
-    filesToUpload = filesToUpload.concat(databaseBundlePath);
+    filesToUpload.push(databaseBundlePath);
   }
 
   await uploadDebugArtifacts(