Simplify doesGoExtractionOutputExist implementation

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
github · Aug 31, 2022 · e466e75 · e466e75
1 parent fff56ee
commit e466e75
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 19 deletions.
diff --git a/lib/analyze-action.js b/lib/analyze-action.js
diff --git a/lib/analyze-action.js.map b/lib/analyze-action.js.map
diff --git a/src/analyze-action.ts b/src/analyze-action.ts
@@ -32,12 +32,12 @@ const pkg = require("../package.json");
 
 interface AnalysisStatusReport
   extends upload_lib.UploadStatusReport,
-    QueriesStatusReport {}
+  QueriesStatusReport { }
 
 interface FinishStatusReport
   extends actionsUtil.StatusReportBase,
-    actionsUtil.DatabaseCreationTimings,
-    AnalysisStatusReport {}
+  actionsUtil.DatabaseCreationTimings,
+  AnalysisStatusReport { }
 
 interface FinishWithTrapUploadStatusReport extends FinishStatusReport {
   /** Size of TRAP caches that we uploaded, in bytes. */
@@ -71,9 +71,9 @@ export async function sendStatusReport(
     ...statusReportBase,
     ...(config
       ? {
-          ml_powered_javascript_queries:
-            util.getMlPoweredJsQueriesStatus(config),
-        }
+        ml_powered_javascript_queries:
+          util.getMlPoweredJsQueriesStatus(config),
+      }
       : {}),
     ...(stats || {}),
     ...(dbCreationTimings || {}),
@@ -106,15 +106,11 @@ function hasBadExpectErrorInput(): boolean {
  */
 function doesGoExtractionOutputExist(config: Config): boolean {
   const golangDbDirectory = util.getCodeQLDatabasePath(config, Language.go);
-  const extractedFiles = fs
+  return fs
     .readdirSync(golangDbDirectory)
-    .filter(
+    .some(
       (fileName) => fileName.endsWith(".trap") || fileName.endsWith(".trap.gz")
     );
-  if (extractedFiles.length !== 0) {
-    return true;
-  }
-  return false;
 }
 
 async function run() {