Downgrade query severity to warning

github · May 16, 2023 · eac5e24 · eac5e24
1 parent 8065746
commit eac5e24
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/queries/default-setup-environment-variables.ql b/queries/default-setup-environment-variables.ql
@@ -2,7 +2,7 @@
  * @name Some environment variables may not exist in default setup workflows
  * @id javascript/codeql-action/default-setup-env-vars
  * @kind problem
- * @severity error
+ * @severity warning
  */
 
 import javascript

diff --git a/queries/default-setup-event-context.ql b/queries/default-setup-event-context.ql
@@ -2,7 +2,7 @@
  * @name Some context properties may not exist in default setup workflows
  * @id javascript/codeql-action/default-setup-context-properties
  * @kind path-problem
- * @severity error
+ * @severity warning
  */
 
 import javascript
@@ -49,16 +49,6 @@ class EventContextAccessConfiguration extends DataFlow::Configuration {
   }
 }
 
-predicate deepPropertyRead(DataFlow::PropRead originalRead, DataFlow::PropRead read, int depth) {
-  read = originalRead and depth = 1
-  or
-  exists(DataFlow::PropRead prevRead, int prevDepth |
-    deepPropertyRead(originalRead, prevRead, prevDepth) and
-    read = prevRead.getAPropertyRead() and
-    depth = prevDepth + 1
-  )
-}
-
 from EventContextAccessConfiguration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
 where
   cfg.hasFlowPath(source, sink) and