Avoid fingerprinting directories

github · May 5, 2021 · f584f94 · f584f94
1 parent 5321045
commit f584f94
Showing 6 changed files with 20 additions and 2 deletions.
diff --git a/lib/fingerprints.js b/lib/fingerprints.js
diff --git a/lib/fingerprints.js.map b/lib/fingerprints.js.map
diff --git a/lib/fingerprints.test.js b/lib/fingerprints.test.js
diff --git a/lib/fingerprints.test.js.map b/lib/fingerprints.test.js.map
diff --git a/src/fingerprints.test.ts b/src/fingerprints.test.ts
@@ -163,6 +163,11 @@ test("resolveUriToFile", (t) => {
   // Invalid indexes are discarded
   t.is(testResolveUriToFile(undefined, 1, [filepath]), undefined);
   t.is(testResolveUriToFile(undefined, "0", [filepath]), undefined);
+
+  // Directories are discarded
+  const dirpath = __dirname;
+  t.is(testResolveUriToFile(dirpath, undefined, []), undefined);
+  t.is(testResolveUriToFile(`file://${dirpath}`, undefined, []), undefined);
 });
 
 test("addFingerprints", (t) => {

diff --git a/src/fingerprints.ts b/src/fingerprints.ts
@@ -227,6 +227,11 @@ export function resolveUriToFile(
     return undefined;
   }
 
+  if (fs.statSync(uri).isDirectory()) {
+    logger.debug(`Unable to compute fingerprint for directory: ${uri}`);
+    return undefined;
+  }
+
   return uri;
 }